From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE
Date: Wed, 30 Jan 2008 01:23:00 -0000 [thread overview]
Message-ID: <20080130010600.GF25780@caradoc.them.org> (raw)
In-Reply-To: <e394668d0712201140x4608e975k4fc03063cfca4cba@mail.gmail.com>
On Thu, Dec 20, 2007 at 11:40:06AM -0800, Doug Evans wrote:
> 2007-12-20 Doug Evans <dje@google.com>
>
> PR 2384
> * gdbtypes.c (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> Return basetype, fieldno if found. All callers updated.
> Don't cache TYPE_VPTR_FIELDNO, TYPE_VPTR_BASETYPE if from different
> objfile.
> * gdbtypes.h (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> * symfile.h (fill_in_vptr_fieldno): Delete.
>
> * gdb.cp/gdb2384.exp: New file.
> * gdb.cp/gdb2384.cc: New file.
> * gdb.cp/gdb2384-base.h: New file.
> * gdb.cp/gdb2384-base.cc: New file.
Thanks, this looks OK. Could you please add copyright notices to the
new test files before committing?
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
> +#gdb_load_shlibs ${sofile}
Why's that commented out?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-30 1:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 0:26 Doug Evans
2007-12-14 6:23 ` Daniel Jacobowitz
2007-12-14 20:44 ` Doug Evans
2007-12-14 21:27 ` Doug Evans
2007-12-15 13:15 ` Doug Evans
2007-12-20 19:49 ` Doug Evans
2008-01-28 19:05 ` Doug Evans
2008-01-30 1:23 ` Daniel Jacobowitz [this message]
2008-02-03 22:19 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130010600.GF25780@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox