From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31086 invoked by alias); 30 Jan 2008 01:06:22 -0000 Received: (qmail 31074 invoked by uid 22791); 30 Jan 2008 01:06:21 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 01:06:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E5F9F98151; Wed, 30 Jan 2008 01:06:01 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id BEEF79811F; Wed, 30 Jan 2008 01:06:01 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JK1Oq-0001zu-Vq; Tue, 29 Jan 2008 20:06:00 -0500 Date: Wed, 30 Jan 2008 01:23:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE Message-ID: <20080130010600.GF25780@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20071214002920.GA1208@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00752.txt.bz2 On Thu, Dec 20, 2007 at 11:40:06AM -0800, Doug Evans wrote: > 2007-12-20 Doug Evans > > PR 2384 > * gdbtypes.c (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno. > Return basetype, fieldno if found. All callers updated. > Don't cache TYPE_VPTR_FIELDNO, TYPE_VPTR_BASETYPE if from different > objfile. > * gdbtypes.h (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno. > * symfile.h (fill_in_vptr_fieldno): Delete. > > * gdb.cp/gdb2384.exp: New file. > * gdb.cp/gdb2384.cc: New file. > * gdb.cp/gdb2384-base.h: New file. > * gdb.cp/gdb2384-base.cc: New file. Thanks, this looks OK. Could you please add copyright notices to the new test files before committing? > +gdb_start > +gdb_reinitialize_dir $srcdir/$subdir > +gdb_load ${binfile} > +#gdb_load_shlibs ${sofile} Why's that commented out? -- Daniel Jacobowitz CodeSourcery