From: "Doug Evans" <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE
Date: Sat, 15 Dec 2007 13:15:00 -0000 [thread overview]
Message-ID: <e394668d0712141326t2abfb73cy3b0b57cdec3bb26e@mail.gmail.com> (raw)
In-Reply-To: <20071214002920.GA1208@caradoc.them.org>
On Dec 13, 2007 4:29 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Thu, Dec 13, 2007 at 04:10:55PM -0800, Doug Evans wrote:
> > Ok to check in? Or any suggestions for what's needed instead?
>
> Your patch seems strange to me. Do we need the new fieldno /
> basetype, or not? If we don't, we shouldn't be calculating it at all;
> if we do, there should be something detectable which breaks when you
> do this. It's not just a cache, since the interface doesn't offer any
> other way to return the new fieldno / basetype besides in-place
> modification.
Hold the fort, I think I see what you're saying now.
I'll send another patch for review.
next prev parent reply other threads:[~2007-12-14 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 0:26 Doug Evans
2007-12-14 6:23 ` Daniel Jacobowitz
2007-12-14 20:44 ` Doug Evans
2007-12-14 21:27 ` Doug Evans
2007-12-15 13:15 ` Doug Evans [this message]
2007-12-20 19:49 ` Doug Evans
2008-01-28 19:05 ` Doug Evans
2008-01-30 1:23 ` Daniel Jacobowitz
2008-02-03 22:19 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0712141326t2abfb73cy3b0b57cdec3bb26e@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox