From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53915-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23999 invoked by alias); 3 Feb 2008 22:19:15 -0000
Received: (qmail 23990 invoked by uid 22791); 3 Feb 2008 22:19:14 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 03 Feb 2008 22:18:57 +0000
Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) 	by smtp-out.google.com with ESMTP id m13MIscL011111 	for <gdb-patches@sourceware.org>; Sun, 3 Feb 2008 14:18:54 -0800
Received: from wa-out-1112.google.com (wafm16.prod.google.com [10.114.189.16]) 	by zps19.corp.google.com with ESMTP id m13MIsk4012151 	for <gdb-patches@sourceware.org>; Sun, 3 Feb 2008 14:18:54 -0800
Received: by wa-out-1112.google.com with SMTP id m16so1887478waf.20         for <gdb-patches@sourceware.org>; Sun, 03 Feb 2008 14:18:54 -0800 (PST)
Received: by 10.114.37.1 with SMTP id k1mr6314135wak.6.1202077133663;         Sun, 03 Feb 2008 14:18:53 -0800 (PST)
Received: by 10.114.13.5 with HTTP; Sun, 3 Feb 2008 14:18:53 -0800 (PST)
Message-ID: <e394668d0802031418p40a9a610j3d5e18a3cfc7f5e1@mail.gmail.com>
Date: Sun, 03 Feb 2008 22:19:00 -0000
From: "Doug Evans" <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE
In-Reply-To: <20080130010600.GF25780@caradoc.them.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <e394668d0712131610w432ee506t38cfd4abfbf6ed7a@mail.gmail.com> 	 <20071214002920.GA1208@caradoc.them.org> 	 <e394668d0712201140x4608e975k4fc03063cfca4cba@mail.gmail.com> 	 <20080130010600.GF25780@caradoc.them.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00061.txt.bz2

On Jan 29, 2008 5:06 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Thu, Dec 20, 2007 at 11:40:06AM -0800, Doug Evans wrote:
> > 2007-12-20  Doug Evans  <dje@google.com>
> >
> >       PR 2384
> >       * gdbtypes.c (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> >       Return basetype, fieldno if found.  All callers updated.
> >       Don't cache TYPE_VPTR_FIELDNO, TYPE_VPTR_BASETYPE if from different
> >       objfile.
> >       * gdbtypes.h (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> >       * symfile.h (fill_in_vptr_fieldno): Delete.
> >
> >       * gdb.cp/gdb2384.exp: New file.
> >       * gdb.cp/gdb2384.cc: New file.
> >       * gdb.cp/gdb2384-base.h: New file.
> >       * gdb.cp/gdb2384-base.cc: New file.
>
> Thanks, this looks OK.  Could you please add copyright notices to the
> new test files before committing?
>
> > +gdb_start
> > +gdb_reinitialize_dir $srcdir/$subdir
> > +gdb_load ${binfile}
> > +#gdb_load_shlibs ${sofile}
>
> Why's that commented out?

Thanks.

Commenting out gdb_load_shlibs was probably a leftover from some
experimentation - I put it back.