From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove most cleanups from linux-thread-db.c
Date: Sat, 24 Feb 2018 02:17:00 -0000 [thread overview]
Message-ID: <e0f21bf7-56db-1e13-1b0f-7ff1189b4a4b@simark.ca> (raw)
In-Reply-To: <20180222170248.27265-1-tom@tromey.com>
Hi Tom,
LGTM, just one nit:
On 2018-02-22 12:02 PM, Tom Tromey wrote:
> @@ -1559,22 +1528,21 @@ thread_db_resume (struct target_ops *ops,
> beneath->to_resume (beneath, ptid, step, signo);
> }
>
> -/* qsort helper function for info_auto_load_libthread_db, sort the
> +/* std:;sort helper function for info_auto_load_libthread_db, sort the
std:;sort -> std::sort
info_auto_load_libthread_db is a little bit hard to follow and there's no
test for it, so I tested it by hand and it seems to work fine with the patch
applied. In order to be able to test it using my system libthread_db, I copied
it to two directories, started two inferiors, setting "set libthread-db-search-path"
to one directory then the other. Otherwise, "info auto-load libthread-db" doesn't
do any meaningful work.
Simon
next prev parent reply other threads:[~2018-02-24 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 17:02 Tom Tromey
2018-02-24 2:17 ` Simon Marchi [this message]
2018-02-25 16:35 ` Simon Marchi
2018-02-25 18:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0f21bf7-56db-1e13-1b0f-7ff1189b4a4b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox