Re: [RFA] Remove most cleanups from linux-thread-db.c

Simon Marchi
2018-02-24T02:17:36Z

Hi Tom,

LGTM, just one nit:

On 2018-02-22 12:02 PM, Tom Tromey wrote:
> @@ -1559,22 +1528,21 @@ thread_db_resume (struct target_ops *ops,
> beneath->to_resume (beneath, ptid, step, signo);
> }
>
> -/* qsort helper function for info_auto_load_libthread_db, sort the
> +/* std:;sort helper function for info_auto_load_libthread_db, sort the

std:;sort -> std::sort

info_auto_load_libthread_db is a little bit hard to follow and there's no
test for it, so I tested it by hand and it seems to work fine with the patch
applied. In order to be able to test it using my system libthread_db, I copied
it to two directories, started two inferiors, setting "set libthread-db-search-path"
to one directory then the other. Otherwise, "info auto-load libthread-db" doesn't
do any meaningful work.

Simon