From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114255 invoked by alias); 24 Feb 2018 02:17:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114236 invoked by uid 89); 24 Feb 2018 02:17:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Feb 2018 02:17:34 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0BC4C1E584; Fri, 23 Feb 2018 21:17:32 -0500 (EST) Subject: Re: [RFA] Remove most cleanups from linux-thread-db.c To: Tom Tromey , gdb-patches@sourceware.org References: <20180222170248.27265-1-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sat, 24 Feb 2018 02:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180222170248.27265-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00351.txt.bz2 Hi Tom, LGTM, just one nit: On 2018-02-22 12:02 PM, Tom Tromey wrote: > @@ -1559,22 +1528,21 @@ thread_db_resume (struct target_ops *ops, > beneath->to_resume (beneath, ptid, step, signo); > } > > -/* qsort helper function for info_auto_load_libthread_db, sort the > +/* std:;sort helper function for info_auto_load_libthread_db, sort the std:;sort -> std::sort info_auto_load_libthread_db is a little bit hard to follow and there's no test for it, so I tested it by hand and it seems to work fine with the patch applied. In order to be able to test it using my system libthread_db, I copied it to two directories, started two inferiors, setting "set libthread-db-search-path" to one directory then the other. Otherwise, "info auto-load libthread-db" doesn't do any meaningful work. Simon