From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove most cleanups from linux-thread-db.c
Date: Sun, 25 Feb 2018 18:00:00 -0000 [thread overview]
Message-ID: <87d10t9cfx.fsf@tromey.com> (raw)
In-Reply-To: <3e9c00376fafb2a9df13bbd1ea855a86@polymtl.ca> (Simon Marchi's message of "Sun, 25 Feb 2018 11:34:53 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> On 2018-02-22 12:02, Tom Tromey wrote:
>> The remaining cleanup in linux-thread-db.c uses
>> make_cleanup_free_char_ptr_vec, which requires a somewhat bigger
>> change.
Simon> I had a patch for that lying around, so I posted it along with other
Simon> cleanup patches to get rid of free_char_ptr_vec here, if you want to
Simon> take a look:
Simon> https://sourceware.org/ml/gdb-patches/2018-02/msg00355.html
I skimmed this series and it looked good to me.
I definitely like the idea and I thought the particular decisions you
made, about when to use string or unique_xmalloc_ptr, made sense.
Tom
prev parent reply other threads:[~2018-02-25 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 17:02 Tom Tromey
2018-02-24 2:17 ` Simon Marchi
2018-02-25 16:35 ` Simon Marchi
2018-02-25 18:00 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d10t9cfx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox