From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21971 invoked by alias); 25 Feb 2018 18:00:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21873 invoked by uid 89); 25 Feb 2018 18:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Feb 2018 18:00:37 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 017C55242 for ; Sun, 25 Feb 2018 12:00:36 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id q0bDewWKfODN4q0bDenSZv; Sun, 25 Feb 2018 12:00:35 -0600 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:45670 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eq0bD-002q4b-Ls; Sun, 25 Feb 2018 12:00:35 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Remove most cleanups from linux-thread-db.c References: <20180222170248.27265-1-tom@tromey.com> <3e9c00376fafb2a9df13bbd1ea855a86@polymtl.ca> Date: Sun, 25 Feb 2018 18:00:00 -0000 In-Reply-To: <3e9c00376fafb2a9df13bbd1ea855a86@polymtl.ca> (Simon Marchi's message of "Sun, 25 Feb 2018 11:34:53 -0500") Message-ID: <87d10t9cfx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eq0bD-002q4b-Ls X-Source-Sender: 174-29-60-18.hlrn.qwest.net (bapiya) [174.29.60.18]:45670 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00361.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-02-22 12:02, Tom Tromey wrote: >> The remaining cleanup in linux-thread-db.c uses >> make_cleanup_free_char_ptr_vec, which requires a somewhat bigger >> change. Simon> I had a patch for that lying around, so I posted it along with other Simon> cleanup patches to get rid of free_char_ptr_vec here, if you want to Simon> take a look: Simon> https://sourceware.org/ml/gdb-patches/2018-02/msg00355.html I skimmed this series and it looked good to me. I definitely like the idea and I thought the particular decisions you made, about when to use string or unique_xmalloc_ptr, made sense. Tom