Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, Andy Wingo <wingo@igalia.com>
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
	       sanjoyd@sourceware.org
Subject: [pushed] Re: Missing test cases for jit-reader interface
Date: Fri, 17 Jun 2016 18:56:00 -0000	[thread overview]
Message-ID: <e03f4a71-8b54-b71c-2d35-22d2e6416d52@redhat.com> (raw)
In-Reply-To: <86y4nmvvme.fsf@gmail.com>

The subject of missing jit reader tests came up again:

 https://sourceware.org/ml/gdb-patches/2016-06/msg00202.html

I've now pushed this in, with a couple trivial modifications mentioned
below.

I left the test arch specific as it was, thinking that it can always
be cleaned up with follow up patches.

On 02/25/2015 03:50 PM, Yao Qi wrote:
> Andy Wingo <wingo@igalia.com> writes:
> 
>> I think it was Sanjoy who forgot to commit these.  Anyway, here is an
>> updated version of the same patch, which passes tests for me.  WDYT?
>>
> 
> Yes, we should add them back since they were reviewed and approved.


> It should be moved into jit_reader_test, after clean_restart, otherwise,
> we'll get the following errors if I run it with --target_board=native-gdbserver.

I did this.

> 
> ERROR: tcl error sourcing /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/jit-reader.exp.
> ERROR: can't read "use_gdb_stub": no such variable

(...)

and also adjusted the number of "../"'s in :

> set jit_reader_header [standard_output_file "../../../gdb/jit-reader.h"]

since the standard output directory moved under testsuite/outputs/ meanwhile.

Thanks,
Pedro Alves


      parent reply	other threads:[~2016-06-17 18:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 10:23 Andy Wingo
2015-02-23 13:11 ` Andy Wingo
2015-02-25  7:38   ` Sanjoy Das
2015-02-25 15:50   ` Yao Qi
2015-02-25 16:23     ` Andy Wingo
2015-02-25 22:39       ` Yao Qi
2015-02-26  9:02         ` Andy Wingo
2016-06-17 18:56     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e03f4a71-8b54-b71c-2d35-22d2e6416d52@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=qiyaoltc@gmail.com \
    --cc=sanjoyd@sourceware.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox