Re: Missing test cases for jit-reader interface

[Andy Wingo <wingo@igalia.com>]

On Wed 25 Feb 2015 16:50, Yao Qi <qiyaoltc@gmail.com> writes:

>> +if { (![istarget x86_64-*-*] && ![istarget i?86-*-*]) || ![is_lp64_target] } {
>> +    return -1;
>> +}
>
> I don't see any reason why this test is arch specific.  We can remove
> such checking, IMO.

The test is arch-specific because it has a simple x86 "jit".  See
jithost.c.

>> +if { ![isnative] } {
>> +    return -1
>> +}
>
> and remove it too.

Does it not need to be this way?  If you are debugging from a big-endian
host, you will read the addresses wrong from the inferior, as the
jit-reader .so reads the values directly.  (Seems to me anyway.)

>> +gdb_load_shlibs "${jit_reader_bin}"
>> +
>
> It should be moved into jit_reader_test, after clean_restart, otherwise,
> we'll get the following errors if I run it with --target_board=native-gdbserver.

ACK.  Will update.

Thanks for the review,

Andy