Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sanjoy Das <sanjoy@playingwithpointers.com>
To: Andy Wingo <wingo@igalia.com>
Cc: gdb-patches@sourceware.org,
	Jan Kratochvil <jan.kratochvil@redhat.com>,
		sanjoyd@sourceware.org
Subject: Re: Missing test cases for jit-reader interface
Date: Wed, 25 Feb 2015 07:38:00 -0000	[thread overview]
Message-ID: <CAMiUf7eJ3XQH_DNRrSvpxSo51w2ZUnPvTANcNYpyq6UBX11A7g@mail.gmail.com> (raw)
In-Reply-To: <87k2z8ydq4.fsf@igalia.com>

This is definitely my fault, I missed actually adding the files when
making the checkin.

Unfortunately I neither have the necessary context in my head to
review this change nor the right SSH keys to check this in.  It will
probably be best if a gdb maintainer takes a look at this.

Thanks,
-- Sanjoy

On Mon, Feb 23, 2015 at 5:11 AM, Andy Wingo <wingo@igalia.com> wrote:
> Hi,
>
> On Mon 23 Feb 2015 11:23, Andy Wingo <wingo@igalia.com> writes:
>
>> In this thread:
>>
>>   http://thread.gmane.org/gmane.comp.gdb.patches/80671/focus=82555
>>
>> There were tests for the jit-reader interface that were to be added to
>> the repo, but they didn't seem to make it in:
>>
>>   $ git show --stat 675921c059dbaddd02ab2eb8a1eaf77b3ac727dd
>>   commit 675921c059dbaddd02ab2eb8a1eaf77b3ac727dd
>>   Author: Sanjoy Das <sanjoyd@sourceware.org>
>>   Date:   Thu Jan 17 14:21:46 2013 +0000
>>
>>       gdb/testsuite
>>
>>        * gdb.base/jit-reader.exp: New file. Test case for the jit-reader
>>          interface.
>>        * gdb.base/jithost.c: New file.
>>        * gdb.base/jithost.h: New file.
>>        * gdb.base/jitreader.c : New file.
>>        * gdb.base/jit-protocol.h: New file.
>>
>>    gdb/testsuite/ChangeLog | 9 +++++++++
>>    1 file changed, 9 insertions(+)
>>
>> Could it be Jan that you forgot to add the new files when you committed
>> Sanjoy's patch?
>
> I think it was Sanjoy who forgot to commit these.  Anyway, here is an
> updated version of the same patch, which passes tests for me.  WDYT?
>


  reply	other threads:[~2015-02-25  7:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 10:23 Andy Wingo
2015-02-23 13:11 ` Andy Wingo
2015-02-25  7:38   ` Sanjoy Das [this message]
2015-02-25 15:50   ` Yao Qi
2015-02-25 16:23     ` Andy Wingo
2015-02-25 22:39       ` Yao Qi
2015-02-26  9:02         ` Andy Wingo
2016-06-17 18:56     ` [pushed] " Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMiUf7eJ3XQH_DNRrSvpxSo51w2ZUnPvTANcNYpyq6UBX11A7g@mail.gmail.com \
    --to=sanjoy@playingwithpointers.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=sanjoyd@sourceware.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox