From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7530 invoked by alias); 25 Feb 2015 07:38:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7511 invoked by uid 89); 25 Feb 2015 07:38:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wg0-f52.google.com Received: from mail-wg0-f52.google.com (HELO mail-wg0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 Feb 2015 07:38:05 +0000 Received: by wggy19 with SMTP id y19so1767829wgg.13 for ; Tue, 24 Feb 2015 23:38:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=lxj2+WM46HopqtLjKkO5wGsBJLea8bFQwfXKRpYBRVU=; b=fyzusIORx812Z4UlKG7E25SV+in/mNUt3E/S3w1oIMAN8iDyDEZeWaMQC68203Ff6V tnBvmfZGvm2qsW8z1DD2GRRq/sR+8ry3eMFoBX9lRGKwSjP4W0g9jGTfN0n9d+eLuzXB rGoz6RQX7DJ5qnL8Irdhixfapi+QGYjrFYIqmeC+2xO8qfjwIPsdIHiUxmgqsiFpAjBD O1nZ/vCWmI9CMSCXMTQvzIvO5tg9/i6JqyctMSiv8z3yRft2xP2zR63RwfjT5mmDSd6Y iTCV88TxQmXFbItlCbtwuZcpqve97yOliLsQPEzYJtmiAdnBQ53kzWB33XF4vD7jzoDz m1kA== X-Gm-Message-State: ALoCoQnlAvooM3jUMWWkOy5r8e1+wAa8FgQQOqvjsVZFc+m7yREZVaVGk+C++dqz2OWXnm/WA3j+ X-Received: by 10.180.87.33 with SMTP id u1mr4045863wiz.20.1424849882036; Tue, 24 Feb 2015 23:38:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.27.8.144 with HTTP; Tue, 24 Feb 2015 23:37:41 -0800 (PST) In-Reply-To: <87k2z8ydq4.fsf@igalia.com> References: <87oaolx6xy.fsf@igalia.com> <87k2z8ydq4.fsf@igalia.com> From: Sanjoy Das Date: Wed, 25 Feb 2015 07:38:00 -0000 Message-ID: Subject: Re: Missing test cases for jit-reader interface To: Andy Wingo Cc: gdb-patches@sourceware.org, Jan Kratochvil , sanjoyd@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-02/txt/msg00703.txt.bz2 This is definitely my fault, I missed actually adding the files when making the checkin. Unfortunately I neither have the necessary context in my head to review this change nor the right SSH keys to check this in. It will probably be best if a gdb maintainer takes a look at this. Thanks, -- Sanjoy On Mon, Feb 23, 2015 at 5:11 AM, Andy Wingo wrote: > Hi, > > On Mon 23 Feb 2015 11:23, Andy Wingo writes: > >> In this thread: >> >> http://thread.gmane.org/gmane.comp.gdb.patches/80671/focus=82555 >> >> There were tests for the jit-reader interface that were to be added to >> the repo, but they didn't seem to make it in: >> >> $ git show --stat 675921c059dbaddd02ab2eb8a1eaf77b3ac727dd >> commit 675921c059dbaddd02ab2eb8a1eaf77b3ac727dd >> Author: Sanjoy Das >> Date: Thu Jan 17 14:21:46 2013 +0000 >> >> gdb/testsuite >> >> * gdb.base/jit-reader.exp: New file. Test case for the jit-reader >> interface. >> * gdb.base/jithost.c: New file. >> * gdb.base/jithost.h: New file. >> * gdb.base/jitreader.c : New file. >> * gdb.base/jit-protocol.h: New file. >> >> gdb/testsuite/ChangeLog | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> Could it be Jan that you forgot to add the new files when you committed >> Sanjoy's patch? > > I think it was Sanjoy who forgot to commit these. Anyway, here is an > updated version of the same patch, which passes tests for me. WDYT? >