From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83385 invoked by alias); 25 Feb 2015 16:23:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83366 invoked by uid 89); 25 Feb 2015 16:23:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: sasl.smtp.pobox.com Received: from pb-sasl1.int.icgroup.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Feb 2015 16:23:30 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id DEF063744A; Wed, 25 Feb 2015 11:23:27 -0500 (EST) Received: from pb-sasl1.int.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id D5CB737449; Wed, 25 Feb 2015 11:23:27 -0500 (EST) Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 1CEFF37448; Wed, 25 Feb 2015 11:23:26 -0500 (EST) From: Andy Wingo To: Yao Qi Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, sanjoyd@sourceware.org Subject: Re: Missing test cases for jit-reader interface References: <87oaolx6xy.fsf@igalia.com> <87k2z8ydq4.fsf@igalia.com> <86y4nmvvme.fsf@gmail.com> Date: Wed, 25 Feb 2015 16:23:00 -0000 In-Reply-To: <86y4nmvvme.fsf@gmail.com> (Yao Qi's message of "Wed, 25 Feb 2015 15:50:01 +0000") Message-ID: <87egpeufib.fsf@igalia.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A0C3D3D8-BD0A-11E4-A0C4-8FDD009B7A5A-02397024!pb-sasl1.pobox.com X-SW-Source: 2015-02/txt/msg00720.txt.bz2 On Wed 25 Feb 2015 16:50, Yao Qi writes: >> +if { (![istarget x86_64-*-*] && ![istarget i?86-*-*]) || ![is_lp64_target] } { >> + return -1; >> +} > > I don't see any reason why this test is arch specific. We can remove > such checking, IMO. The test is arch-specific because it has a simple x86 "jit". See jithost.c. >> +if { ![isnative] } { >> + return -1 >> +} > > and remove it too. Does it not need to be this way? If you are debugging from a big-endian host, you will read the addresses wrong from the inferior, as the jit-reader .so reads the values directly. (Seems to me anyway.) >> +gdb_load_shlibs "${jit_reader_bin}" >> + > > It should be moved into jit_reader_test, after clean_restart, otherwise, > we'll get the following errors if I run it with --target_board=native-gdbserver. ACK. Will update. Thanks for the review, Andy