From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68446 invoked by alias); 17 Jun 2016 18:56:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68422 invoked by uid 89); 17 Jun 2016 18:56:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Jun 2016 18:56:25 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9493B64461; Fri, 17 Jun 2016 18:56:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5HIuLSP009757; Fri, 17 Jun 2016 14:56:22 -0400 Subject: [pushed] Re: Missing test cases for jit-reader interface To: Yao Qi , Andy Wingo References: <87oaolx6xy.fsf@igalia.com> <87k2z8ydq4.fsf@igalia.com> <86y4nmvvme.fsf@gmail.com> Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, sanjoyd@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 17 Jun 2016 18:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <86y4nmvvme.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00308.txt.bz2 The subject of missing jit reader tests came up again: https://sourceware.org/ml/gdb-patches/2016-06/msg00202.html I've now pushed this in, with a couple trivial modifications mentioned below. I left the test arch specific as it was, thinking that it can always be cleaned up with follow up patches. On 02/25/2015 03:50 PM, Yao Qi wrote: > Andy Wingo writes: > >> I think it was Sanjoy who forgot to commit these. Anyway, here is an >> updated version of the same patch, which passes tests for me. WDYT? >> > > Yes, we should add them back since they were reviewed and approved. > It should be moved into jit_reader_test, after clean_restart, otherwise, > we'll get the following errors if I run it with --target_board=native-gdbserver. I did this. > > ERROR: tcl error sourcing /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/jit-reader.exp. > ERROR: can't read "use_gdb_stub": no such variable (...) and also adjusted the number of "../"'s in : > set jit_reader_header [standard_output_file "../../../gdb/jit-reader.h"] since the standard output directory moved under testsuite/outputs/ meanwhile. Thanks, Pedro Alves