Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Mihails Strasuns <mihails.strasuns@intel.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests
Date: Sun, 29 Mar 2020 23:00:28 -0400	[thread overview]
Message-ID: <df4fb826-46f9-23fb-397d-bd3250e5e637@simark.ca> (raw)
In-Reply-To: <20200327103932.17765-4-mihails.strasuns@intel.com>

On 2020-03-27 6:39 a.m., Mihails Strasuns via Gdb-patches wrote:
> Old usage: jit-elf-main lib.so 2
> New usage: jit-elf-main lib.so.1 lib.so.2
> 
> Refactoring necessary to support running tests over multiple jit
> binaries rather than mapping the same binary muultiple times.
> 
> gdb/testsuite/ChangeLog:
> 
> 2020-02-18  Mihails Strasuns  <mihails.strasuns@intel.com>
> 
> 	* gdb.base/jit-elf-main.c: read lib list from argc/argv
> 	* gdb.base/jit-elf.exp: compile N jit libraries and use the list
> 	* gdb.base/jit-elf-so.exp: ditto
> 
> Change-Id: Ie8f85ec6358604c14557b0417d6621b2f8942033
> Signed-off-by: Mihails Strasuns <mihails.strasuns@intel.com>

Hmm, it seems like many comments from these messages were not addressed:

https://sourceware.org/pipermail/gdb-patches/2020-March/166923.html
https://sourceware.org/pipermail/gdb-patches/2020-March/166924.html

Simon



  reply	other threads:[~2020-03-30  3:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165972>
2020-03-27 10:39 ` [PATCH v2 1/8] [gdb/testsuite] allow more registers in reader test Mihails Strasuns
2020-03-27 10:39   ` [PATCH v2 2/8] [gdb/testsuite] structured rename of jit test files Mihails Strasuns
2020-03-27 10:39   ` [PATCH v2 3/8] [gdb/testsuite] share jit-protocol.h by all jit tests Mihails Strasuns
2020-03-27 10:39   ` [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-03-30  3:00     ` Simon Marchi [this message]
2020-03-31 15:13       ` Strasuns, Mihails
2020-03-31 16:08         ` Simon Marchi
2020-03-27 10:39   ` [PATCH v2 5/8] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-03-27 10:39   ` [PATCH v2 6/8] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-03-27 10:39   ` [PATCH v2 7/8] [gdb/testsuite] define jit function name via macro Mihails Strasuns
2020-03-27 10:39   ` [PATCH v2 8/8] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-03-30  2:55   ` [PATCH v2 1/8] [gdb/testsuite] allow more registers in reader test Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df4fb826-46f9-23fb-397d-bd3250e5e637@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=mihails.strasuns@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox