RE: [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests

["Strasuns, Mihails" <mihails.strasuns@intel.com>]

> -----Original Message-----
> From: Simon Marchi <simark@simark.ca>
> Sent: Monday, March 30, 2020 5:00 AM
> To: Strasuns, Mihails <mihails.strasuns@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests
> 
> On 2020-03-27 6:39 a.m., Mihails Strasuns via Gdb-patches wrote:
> > Old usage: jit-elf-main lib.so 2
> > New usage: jit-elf-main lib.so.1 lib.so.2
> >
> > Refactoring necessary to support running tests over multiple jit
> > binaries rather than mapping the same binary muultiple times.
> >
> > gdb/testsuite/ChangeLog:
> >
> > 2020-02-18  Mihails Strasuns  <mihails.strasuns@intel.com>
> >
> > 	* gdb.base/jit-elf-main.c: read lib list from argc/argv
> > 	* gdb.base/jit-elf.exp: compile N jit libraries and use the list
> > 	* gdb.base/jit-elf-so.exp: ditto
> >
> > Change-Id: Ie8f85ec6358604c14557b0417d6621b2f8942033
> > Signed-off-by: Mihails Strasuns <mihails.strasuns@intel.com>
> 
> Hmm, it seems like many comments from these messages were not
> addressed:

Hello,

Sorry, I have indeed missed these review mails. Will upload v3 in a moment, only one question:

> If we fail to compile something, do we want to return some failure return status
and exit the test?  This is how it works currently.

What do you mean here? That you would prefer to switch from untested to fail? It used to result in untested in the original test.

BR,
Mihails
 
> https://sourceware.org/pipermail/gdb-patches/2020-March/166923.html
> https://sourceware.org/pipermail/gdb-patches/2020-March/166924.html
> 
> Simon

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928