From: Simon Marchi <simark@simark.ca>
To: "Strasuns, Mihails" <mihails.strasuns@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests
Date: Tue, 31 Mar 2020 12:08:01 -0400 [thread overview]
Message-ID: <ec73e958-650f-7189-1172-1a094925d098@simark.ca> (raw)
In-Reply-To: <MWHPR11MB0048132B52A5AF1FB03AB17A95C80@MWHPR11MB0048.namprd11.prod.outlook.com>
On 2020-03-31 11:13 a.m., Strasuns, Mihails via Gdb-patches wrote:
> What do you mean here? That you would prefer to switch from untested to fail? It used to result in untested in the original test.
In the current test case, if we fail to compile the test, we call "return -1", which
skips the execution of the rest of the test. We don't want to keep executing the test if
the compilation failed. I'd suggest that your new compile functions also returns something
to indicate to the caller that the compilation failed, so the caller can also return early.
Does that make sense?
Simon
next prev parent reply other threads:[~2020-03-31 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165972>
2020-03-27 10:39 ` [PATCH v2 1/8] [gdb/testsuite] allow more registers in reader test Mihails Strasuns
2020-03-27 10:39 ` [PATCH v2 2/8] [gdb/testsuite] structured rename of jit test files Mihails Strasuns
2020-03-27 10:39 ` [PATCH v2 3/8] [gdb/testsuite] share jit-protocol.h by all jit tests Mihails Strasuns
2020-03-27 10:39 ` [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-03-30 3:00 ` Simon Marchi
2020-03-31 15:13 ` Strasuns, Mihails
2020-03-31 16:08 ` Simon Marchi [this message]
2020-03-27 10:39 ` [PATCH v2 5/8] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-03-27 10:39 ` [PATCH v2 6/8] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-03-27 10:39 ` [PATCH v2 7/8] [gdb/testsuite] define jit function name via macro Mihails Strasuns
2020-03-27 10:39 ` [PATCH v2 8/8] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-03-30 2:55 ` [PATCH v2 1/8] [gdb/testsuite] allow more registers in reader test Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec73e958-650f-7189-1172-1a094925d098@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mihails.strasuns@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox