From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0C5DE385B835 for ; Mon, 30 Mar 2020 03:00:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C5DE385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8AC7C1E5F8; Sun, 29 Mar 2020 23:00:28 -0400 (EDT) Subject: Re: [PATCH v2 4/8] [gdb/testsuite] use args as lib list for jit-elf tests To: Mihails Strasuns , gdb-patches@sourceware.org References: <165972> <20200327103932.17765-1-mihails.strasuns@intel.com> <20200327103932.17765-4-mihails.strasuns@intel.com> From: Simon Marchi Message-ID: Date: Sun, 29 Mar 2020 23:00:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200327103932.17765-4-mihails.strasuns@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 03:00:30 -0000 On 2020-03-27 6:39 a.m., Mihails Strasuns via Gdb-patches wrote: > Old usage: jit-elf-main lib.so 2 > New usage: jit-elf-main lib.so.1 lib.so.2 > > Refactoring necessary to support running tests over multiple jit > binaries rather than mapping the same binary muultiple times. > > gdb/testsuite/ChangeLog: > > 2020-02-18 Mihails Strasuns > > * gdb.base/jit-elf-main.c: read lib list from argc/argv > * gdb.base/jit-elf.exp: compile N jit libraries and use the list > * gdb.base/jit-elf-so.exp: ditto > > Change-Id: Ie8f85ec6358604c14557b0417d6621b2f8942033 > Signed-off-by: Mihails Strasuns Hmm, it seems like many comments from these messages were not addressed: https://sourceware.org/pipermail/gdb-patches/2020-March/166923.html https://sourceware.org/pipermail/gdb-patches/2020-March/166924.html Simon