From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 5/8] gdb/dwarf: generate foreign type units in .debug_names
Date: Sat, 9 May 2026 14:30:33 -0400 [thread overview]
Message-ID: <dce520b0-f1d5-4c8c-9ad4-ab6dc56a9499@simark.ca> (raw)
In-Reply-To: <87ecjykjop.fsf@tromey.com>
On 4/28/26 2:45 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> + if (per_cu == nullptr)
> Simon> + error (_("Could not find a CU for foreign type unit in "
> Simon> + "DWO file %s"),
> Simon> + sig_type->dwo_unit->dwo_file->dwo_name.c_str ());
>
> It's possible to style error messages now.
>
> Though I don't know if we really care about this one. FTR I did not
> bother to convert a few similar things in the DWARF reader.
>
> Approved-By: Tom Tromey <tom@tromey.com>
I replaced it with:
error (_("Could not find a CU for foreign type unit in "
"DWO file %ps"),
styled_string (file_name_style.style (),
(sig_type->dwo_unit->dwo_file
->dwo_name.c_str ())));
Simon
next prev parent reply other threads:[~2026-05-09 18:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 23:19 [PATCH 0/8] Handle " simon.marchi
2026-03-16 23:19 ` [PATCH 1/8] gdb/dwarf: refuse to produce .gdb_index when skeletonless type units are present simon.marchi
2026-03-17 12:57 ` Eli Zaretskii
2026-04-16 19:43 ` Simon Marchi
2026-03-16 23:19 ` [PATCH 2/8] gdb/dwarf: move dwo_unit and dwo_file to read.h simon.marchi
2026-03-16 23:19 ` [PATCH 3/8] gdb/dwarf: move dwarf2_cu::section to cu.c simon.marchi
2026-03-16 23:19 ` [PATCH 4/8] gdb/dwarf: add dwo_file::find_tus simon.marchi
2026-03-16 23:19 ` [PATCH 5/8] gdb/dwarf: generate foreign type units in .debug_names simon.marchi
2026-03-16 23:19 ` [PATCH 6/8] gdb/dwarf: add debug output in read-debug-names.c simon.marchi
2026-03-16 23:19 ` [PATCH 7/8] gdb/dwarf: add more context to complaints in mapped_debug_names_reader::scan_one_entry simon.marchi
2026-03-16 23:19 ` [PATCH 8/8] gdb/dwarf: read foreign type units simon.marchi
2026-04-16 19:59 ` [PATCH v2 0/8] Handle foreign type units in .debug_names Simon Marchi
2026-04-16 19:59 ` [PATCH v2 1/8] gdb: refuse to produce .gdb_index when skeletonless type units are present Simon Marchi
2026-04-17 7:10 ` Eli Zaretskii
[not found] ` <87v7dbj5zg.fsf@tromey.com>
2026-05-08 22:57 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 2/8] gdb/dwarf: move dwo_unit and dwo_file to read.h Simon Marchi
2026-04-28 18:30 ` Tom Tromey
2026-05-08 22:59 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 3/8] gdb/dwarf: move dwarf2_cu::section to cu.c Simon Marchi
2026-04-28 18:31 ` Tom Tromey
2026-04-16 19:59 ` [PATCH v2 4/8] gdb/dwarf: add dwo_file::find_tus Simon Marchi
2026-04-28 18:32 ` Tom Tromey
2026-04-16 19:59 ` [PATCH v2 5/8] gdb/dwarf: generate foreign type units in .debug_names Simon Marchi
2026-04-28 18:45 ` Tom Tromey
2026-05-09 18:30 ` Simon Marchi [this message]
2026-04-16 19:59 ` [PATCH v2 6/8] gdb/dwarf: add debug output in read-debug-names.c Simon Marchi
2026-04-28 18:50 ` Tom Tromey
2026-04-16 19:59 ` [PATCH v2 7/8] gdb/dwarf: add more context to complaints in mapped_debug_names_reader::scan_one_entry Simon Marchi
2026-04-28 18:57 ` Tom Tromey
2026-05-09 18:44 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 8/8] gdb/dwarf: read foreign type units Simon Marchi
2026-04-28 19:33 ` Tom Tromey
2026-05-09 19:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce520b0-f1d5-4c8c-9ad4-ab6dc56a9499@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox