Re: [PATCH v2 7/8] gdb/dwarf: add more context to complaints in mapped_debug_names_reader::scan_one_entry

[Simon Marchi <simon.marchi@efficios.com>]

On 4/28/26 2:57 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> I realize that complaints are not often enabled and shown, but if we
> Simon> emit them, I think they should include enough context to help a user who
> Simon> wishes to dig in the problem to pinpoint where the problem happened
> Simon> exactly.
> 
> Makes sense.  Though I continue to maintain that no such user exists and
> that complaints are pointless.

When GDB encounters something weird and ignores it because it doesn't
understand it, I think it's valuable to have a trace somewhere.  But
I'd be fine if we converted them to debug prints, for example.

> Simon> I am not attached to the particular format.  I thought that because this
> Simon> is extra contextual information, I would put it in the square brackets
> Simon> at the end (which only shows the module name currently).  However, it
> Simon> would be nice to converge towards a format that we could replicate
> Simon> elsewhere in the DWARF reader, so feel free to chime in.
> 
> I don't think it's worth bikeshedding over and anyway it can always
> easily be changed.
> 
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom