From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v2 7/8] gdb/dwarf: add more context to complaints in mapped_debug_names_reader::scan_one_entry
Date: Tue, 28 Apr 2026 12:57:28 -0600 [thread overview]
Message-ID: <875x5akj53.fsf@tromey.com> (raw)
In-Reply-To: <20260416200256.386186-8-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 16 Apr 2026 15:59:10 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> I realize that complaints are not often enabled and shown, but if we
Simon> emit them, I think they should include enough context to help a user who
Simon> wishes to dig in the problem to pinpoint where the problem happened
Simon> exactly.
Makes sense. Though I continue to maintain that no such user exists and
that complaints are pointless.
Simon> I am not attached to the particular format. I thought that because this
Simon> is extra contextual information, I would put it in the square brackets
Simon> at the end (which only shows the module name currently). However, it
Simon> would be nice to converge towards a format that we could replicate
Simon> elsewhere in the DWARF reader, so feel free to chime in.
I don't think it's worth bikeshedding over and anyway it can always
easily be changed.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-04-28 18:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 23:19 [PATCH 0/8] Handle foreign type units in .debug_names simon.marchi
2026-03-16 23:19 ` [PATCH 1/8] gdb/dwarf: refuse to produce .gdb_index when skeletonless type units are present simon.marchi
2026-03-17 12:57 ` Eli Zaretskii
2026-04-16 19:43 ` Simon Marchi
2026-03-16 23:19 ` [PATCH 2/8] gdb/dwarf: move dwo_unit and dwo_file to read.h simon.marchi
2026-03-16 23:19 ` [PATCH 3/8] gdb/dwarf: move dwarf2_cu::section to cu.c simon.marchi
2026-03-16 23:19 ` [PATCH 4/8] gdb/dwarf: add dwo_file::find_tus simon.marchi
2026-03-16 23:19 ` [PATCH 5/8] gdb/dwarf: generate foreign type units in .debug_names simon.marchi
2026-03-16 23:19 ` [PATCH 6/8] gdb/dwarf: add debug output in read-debug-names.c simon.marchi
2026-03-16 23:19 ` [PATCH 7/8] gdb/dwarf: add more context to complaints in mapped_debug_names_reader::scan_one_entry simon.marchi
2026-03-16 23:19 ` [PATCH 8/8] gdb/dwarf: read foreign type units simon.marchi
2026-04-16 19:59 ` [PATCH v2 0/8] Handle foreign type units in .debug_names Simon Marchi
2026-04-16 19:59 ` [PATCH v2 1/8] gdb: refuse to produce .gdb_index when skeletonless type units are present Simon Marchi
2026-04-17 7:10 ` Eli Zaretskii
[not found] ` <87v7dbj5zg.fsf@tromey.com>
2026-05-08 22:57 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 2/8] gdb/dwarf: move dwo_unit and dwo_file to read.h Simon Marchi
2026-04-28 18:30 ` Tom Tromey
2026-05-08 22:59 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 3/8] gdb/dwarf: move dwarf2_cu::section to cu.c Simon Marchi
2026-04-28 18:31 ` Tom Tromey
2026-04-16 19:59 ` [PATCH v2 4/8] gdb/dwarf: add dwo_file::find_tus Simon Marchi
2026-04-28 18:32 ` Tom Tromey
2026-04-16 19:59 ` [PATCH v2 5/8] gdb/dwarf: generate foreign type units in .debug_names Simon Marchi
2026-04-28 18:45 ` Tom Tromey
2026-05-09 18:30 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 6/8] gdb/dwarf: add debug output in read-debug-names.c Simon Marchi
2026-04-28 18:50 ` Tom Tromey
2026-04-16 19:59 ` [PATCH v2 7/8] gdb/dwarf: add more context to complaints in mapped_debug_names_reader::scan_one_entry Simon Marchi
2026-04-28 18:57 ` Tom Tromey [this message]
2026-05-09 18:44 ` Simon Marchi
2026-04-16 19:59 ` [PATCH v2 8/8] gdb/dwarf: read foreign type units Simon Marchi
2026-04-28 19:33 ` Tom Tromey
2026-05-09 19:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x5akj53.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox