From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qbAyD3V9/2nMkSkAWB0awg (envelope-from ) for ; Sat, 09 May 2026 14:31:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1778351477; bh=m3BxxyiTez9wUHpfw0sRSeZgOB38x2Z8d9gsDKE8Scg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EO1jORPjXHMKLwaaXSrGLEv2oiVmZTOcnxYKDfhesyw2HZAm60GMwtc/RlX24x8gS Du3A49zF6+eAsRy/tfsbqUfVqvCGVbHGtqr4lIx5GD+mG+4rDJqM/3TFeShKtNDr+K DE03DmkMlTcGy+2iwwGIa8+GjhtNKsRhGDcFakeM= Received: by simark.ca (Postfix, from userid 112) id 2AFC61E067; Sat, 09 May 2026 14:31:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=dVplqnMI; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E25C51E067 for ; Sat, 09 May 2026 14:31:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 688C94BA2E3E for ; Sat, 9 May 2026 18:31:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 688C94BA2E3E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=dVplqnMI Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 614B54BA2E12 for ; Sat, 9 May 2026 18:30:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 614B54BA2E12 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 614B54BA2E12 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778351436; cv=none; b=ms6Cpkene17SNvbSWvzSdPK1ZBlxjNXuJt5ar5WDifCH8AHy8+qXPqZilNIgpmMxMQue0iLjEZDgp8KqXsqBnG//jkcgM1Zep6giVAmHXMrT7lG+aZfn2IKDojN7DcpoQWgucqaGTWxbSkZHFAePooKRbey6p8mB4DnmnqC5lyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778351436; c=relaxed/simple; bh=m3BxxyiTez9wUHpfw0sRSeZgOB38x2Z8d9gsDKE8Scg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GEJzhiK2hOAFQmdGD7Uh3Yux/y8Vw3o5emTLPgZcBLlXgjW2RDKb+J0IhuOcCgvr8T4v5S8XVciCiwxFMJNK9csxRXt4UhyWMxV31SeqcmW8ZtqAl8zRVzeqakAjwXRhiasLRhreZqtQVD4vLXx8VLsSDOoHYwQkSQDpfDzRctQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=dVplqnMI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 614B54BA2E12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1778351433; bh=m3BxxyiTez9wUHpfw0sRSeZgOB38x2Z8d9gsDKE8Scg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dVplqnMIHpumebZgSV+tTvPIcFmz4wb/zJ05sCI4cuwnNNdBQc1+drFG9k2KUN/9u 6HPgfdD10BSpkZOpz1bF/2EtbqHkQgn8VgdHmIAvWGTZbeh1KIjCm0UL8CanDCK7yB MeZ4Q+DmXy8XlfyX6+ArKiqxtaMURF5Guj7ja5uU= Received: by simark.ca (Postfix) id ABD211E067; Sat, 09 May 2026 14:30:33 -0400 (EDT) Message-ID: Date: Sat, 9 May 2026 14:30:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] gdb/dwarf: generate foreign type units in .debug_names To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260316232042.368080-1-simon.marchi@polymtl.ca> <20260416200256.386186-1-simon.marchi@efficios.com> <20260416200256.386186-6-simon.marchi@efficios.com> <87ecjykjop.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ecjykjop.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/26 2:45 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> + if (per_cu == nullptr) > Simon> + error (_("Could not find a CU for foreign type unit in " > Simon> + "DWO file %s"), > Simon> + sig_type->dwo_unit->dwo_file->dwo_name.c_str ()); > > It's possible to style error messages now. > > Though I don't know if we really care about this one. FTR I did not > bother to convert a few similar things in the DWARF reader. > > Approved-By: Tom Tromey I replaced it with: error (_("Could not find a CU for foreign type unit in " "DWO file %ps"), styled_string (file_name_style.style (), (sig_type->dwo_unit->dwo_file ->dwo_name.c_str ()))); Simon