Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Pierre Muller <muller@ics.u-strasbg.fr>,
	ppluzhnikov@google.com, msnyder@vmware.com,
	 	gdb-patches@sourceware.org
Subject: Re: [RFA, 3 of 3] save/restore process record, part 3 (save/restore)
Date: Fri, 23 Oct 2009 14:42:00 -0000	[thread overview]
Message-ID: <daef60380910230742y69b8942esd78f95a18d511c52@mail.gmail.com> (raw)
In-Reply-To: <837humh1bn.fsf@gnu.org>

Thanks guys,

I changed the this 0x%08x to phex_nz.
Committed following patch as obvious.

Thanks,
Hui

===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.10995
retrieving revision 1.10996
diff -u -r1.10995 -r1.10996
--- src/gdb/ChangeLog	2009/10/23 14:31:33	1.10995
+++ src/gdb/ChangeLog	2009/10/23 14:35:29	1.10996
@@ -1,3 +1,7 @@
+2009-10-23  Hui Zhu  <teawater@gmail.com>
+
+	* record.c (record_restore): Use phex_nz.
+
 2009-10-23  Tristan Gingold  <gingold@adacore.com>

 	* frame.c (frame_unwind_pc): Fix typo: remove duplicate 0x.


===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- src/gdb/record.c	2009/10/23 01:00:35	1.31
+++ src/gdb/record.c	2009/10/23 14:35:30	1.32
@@ -2017,8 +2017,8 @@
 	   bfd_get_filename (core_bfd));
   if (record_debug)
     printf_filtered ("\
-  Reading 4-byte magic cookie RECORD_FILE_MAGIC (0x%08x)\n",
-		     netorder32 (magic));
+  Reading 4-byte magic cookie RECORD_FILE_MAGIC (0x%s)\n",
+		     phex_nz (netorder32 (magic), 4));

   /* Restore the entries in recfd into record_arch_list_head and
      record_arch_list_tail.  */
@@ -2284,8 +2284,8 @@
   magic = RECORD_FILE_MAGIC;
   if (record_debug)
     printf_filtered ("\
-  Writing 4-byte magic cookie RECORD_FILE_MAGIC (0x%08x)\n",
-		     magic);
+  Writing 4-byte magic cookie RECORD_FILE_MAGIC (0x%s)\n",
+		     phex_nz (magic, 4));
   bfdcore_write (obfd, osec, &magic, sizeof (magic), &bfd_offset);

   /* Save the entries to recfd and forward execute to the end of


  reply	other threads:[~2009-10-23 14:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-17  1:32 Michael Snyder
2009-10-17  8:31 ` Eli Zaretskii
2009-10-17 18:42   ` Michael Snyder
2009-10-17 20:11     ` Eli Zaretskii
2009-10-17 22:19       ` Michael Snyder
2009-10-18  2:23         ` Hui Zhu
2009-10-18  3:59           ` Michael Snyder
2009-10-18  4:06         ` Eli Zaretskii
2009-10-18  4:10           ` Michael Snyder
2009-10-19  4:34             ` Hui Zhu
2009-10-19 18:00               ` Michael Snyder
2009-10-20  2:47                 ` Hui Zhu
2009-10-20 20:03                   ` Michael Snyder
2009-10-20 20:05                     ` Michael Snyder
2009-10-21  2:36                       ` Hui Zhu
2009-10-22 19:42                         ` Michael Snyder
2009-10-22 20:40                           ` Paul Pluzhnikov
2009-10-22 21:00                             ` Michael Snyder
2009-10-22 21:25                               ` Paul Pluzhnikov
2009-10-23  0:45                                 ` Paul Pluzhnikov
2009-10-23  1:05                                   ` Paul Pluzhnikov
2009-10-23  5:35                                     ` Hui Zhu
2009-10-23  8:52                                     ` Pierre Muller
2009-10-23 10:08                                       ` Eli Zaretskii
2009-10-23 14:42                                         ` Hui Zhu [this message]
2009-10-23 14:54                                           ` Pedro Alves
2009-10-31 14:57                                             ` Pedro Alves
2009-11-01  9:54                                               ` Hui Zhu
2009-10-23 14:58                                           ` Pedro Alves
2009-10-23 14:46                                         ` Andreas Schwab
2009-10-23 14:55                                           ` Eli Zaretskii
2009-10-23 15:35                                             ` Andreas Schwab
2009-10-23 15:48                                               ` Eli Zaretskii
2009-10-23 16:31                                                 ` Andreas Schwab
2009-10-23 15:09                                         ` Pierre Muller
2009-10-23  5:35                           ` Hui Zhu
2009-10-23 15:56                             ` Michael Snyder
2009-10-23 16:01                               ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380910230742y69b8942esd78f95a18d511c52@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=muller@ics.u-strasbg.fr \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox