From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31639 invoked by alias); 23 Oct 2009 14:42:27 -0000 Received: (qmail 31630 invoked by uid 22791); 23 Oct 2009 14:42:26 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f175.google.com (HELO mail-px0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Oct 2009 14:42:21 +0000 Received: by pxi5 with SMTP id 5so5279606pxi.12 for ; Fri, 23 Oct 2009 07:42:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.20.10 with SMTP id x10mr926305wfi.224.1256308940079; Fri, 23 Oct 2009 07:42:20 -0700 (PDT) In-Reply-To: <837humh1bn.fsf@gnu.org> References: <4AD91D72.1030802@vmware.com> <4AE0B40B.5020802@vmware.com> <8ac60eac0910221340y2ad104fo5e4229f017957a5b@mail.gmail.com> <4AE0C669.5020001@vmware.com> <8ac60eac0910221425q63b78a7cnb92b0ddf1c8f5e61@mail.gmail.com> <8ac60eac0910221745t3ef6eb56ra6609086ad07f23@mail.gmail.com> <8ac60eac0910221803p2b45453bu17473aa7e9453a60@mail.gmail.com> <006001ca53be$25d1ab70$71750250$@u-strasbg.fr> <837humh1bn.fsf@gnu.org> From: Hui Zhu Date: Fri, 23 Oct 2009 14:42:00 -0000 Message-ID: Subject: Re: [RFA, 3 of 3] save/restore process record, part 3 (save/restore) To: Eli Zaretskii Cc: Pierre Muller , ppluzhnikov@google.com, msnyder@vmware.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00575.txt.bz2 Thanks guys, I changed the this 0x%08x to phex_nz. Committed following patch as obvious. Thanks, Hui =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.10995 retrieving revision 1.10996 diff -u -r1.10995 -r1.10996 --- src/gdb/ChangeLog 2009/10/23 14:31:33 1.10995 +++ src/gdb/ChangeLog 2009/10/23 14:35:29 1.10996 @@ -1,3 +1,7 @@ +2009-10-23 Hui Zhu + + * record.c (record_restore): Use phex_nz. + 2009-10-23 Tristan Gingold * frame.c (frame_unwind_pc): Fix typo: remove duplicate 0x. =================================================================== RCS file: /cvs/src/src/gdb/record.c,v retrieving revision 1.31 retrieving revision 1.32 diff -u -r1.31 -r1.32 --- src/gdb/record.c 2009/10/23 01:00:35 1.31 +++ src/gdb/record.c 2009/10/23 14:35:30 1.32 @@ -2017,8 +2017,8 @@ bfd_get_filename (core_bfd)); if (record_debug) printf_filtered ("\ - Reading 4-byte magic cookie RECORD_FILE_MAGIC (0x%08x)\n", - netorder32 (magic)); + Reading 4-byte magic cookie RECORD_FILE_MAGIC (0x%s)\n", + phex_nz (netorder32 (magic), 4)); /* Restore the entries in recfd into record_arch_list_head and record_arch_list_tail. */ @@ -2284,8 +2284,8 @@ magic = RECORD_FILE_MAGIC; if (record_debug) printf_filtered ("\ - Writing 4-byte magic cookie RECORD_FILE_MAGIC (0x%08x)\n", - magic); + Writing 4-byte magic cookie RECORD_FILE_MAGIC (0x%s)\n", + phex_nz (magic, 4)); bfdcore_write (obfd, osec, &magic, sizeof (magic), &bfd_offset); /* Save the entries to recfd and forward execute to the end of