Re: [RFA, 3 of 3] save/restore process record, part 3 (save/restore)

[Paul Pluzhnikov <ppluzhnikov@google.com>]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

On Thu, Oct 22, 2009 at 5:45 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:

> More problems: on Linux/x86_64:
>

> ../../src/gdb/record.c:2062: warning: format '%d' expects type 'int',
> but argument 3 has type 'long unsigned int'

I've committed attached patch as obvious.

Thanks,
-- 
Paul Pluzhnikov

2009-10-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* record.c (record_restore, cmd_record_save): Fix warnings.

[-- Attachment #2: gdb-fixup-20091022.txt --]
[-- Type: text/plain, Size: 3024 bytes --]

Index: record.c
===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.30
diff -u -p -u -r1.30 record.c
--- record.c	22 Oct 2009 19:36:06 -0000	1.30
+++ record.c	23 Oct 2009 00:58:23 -0000
@@ -2056,9 +2056,9 @@ record_restore (void)
 
           if (record_debug)
             printf_filtered ("\
-  Reading register %d (1 plus %d plus %d bytes)\n",
+  Reading register %d (1 plus %lu plus %d bytes)\n",
 			     rec->u.reg.num,
-			     sizeof (regnum),
+			     (unsigned long) sizeof (regnum),
 			     rec->u.reg.len);
           break;
 
@@ -2081,11 +2081,11 @@ record_restore (void)
 
           if (record_debug)
             printf_filtered ("\
-  Reading memory %s (1 plus %d plus %d plus %d bytes)\n",
+  Reading memory %s (1 plus %lu plus %lu plus %d bytes)\n",
 			     paddress (get_current_arch (),
 				       rec->u.mem.addr),
-			     sizeof (addr),
-			     sizeof (len),
+			     (unsigned long) sizeof (addr),
+			     (unsigned long) sizeof (len),
 			     rec->u.mem.len);
           break;
 
@@ -2107,9 +2107,9 @@ record_restore (void)
 	  record_insn_count = count + 1;
           if (record_debug)
             printf_filtered ("\
-  Reading record_end (1 + %d + %d bytes), offset == %s\n",
-			     sizeof (signal),
-			     sizeof (count),
+  Reading record_end (1 + %lu + %lu bytes), offset == %s\n",
+			     (unsigned long) sizeof (signal),
+			     (unsigned long) sizeof (count),
 			     paddress (get_current_arch (),
 				       bfd_offset));
           break;
@@ -2308,9 +2308,9 @@ cmd_record_save (char *args, int from_tt
             case record_reg: /* reg */
               if (record_debug)
 		printf_filtered ("\
-  Writing register %d (1 plus %d plus %d bytes)\n",
+  Writing register %d (1 plus %lu plus %d bytes)\n",
 				 record_list->u.reg.num,
-				 sizeof (regnum),
+				 (unsigned long) sizeof (regnum),
 				 record_list->u.reg.len);
 
               /* Write regnum.  */
@@ -2326,11 +2326,11 @@ cmd_record_save (char *args, int from_tt
             case record_mem: /* mem */
 	      if (record_debug)
 		printf_filtered ("\
-  Writing memory %s (1 plus %d plus %d plus %d bytes)\n",
+  Writing memory %s (1 plus %lu plus %lu plus %d bytes)\n",
 				 paddress (gdbarch,
 					   record_list->u.mem.addr),
-				 sizeof (addr),
-				 sizeof (len),
+				 (unsigned long) sizeof (addr),
+				 (unsigned long) sizeof (len),
 				 record_list->u.mem.len);
 
 	      /* Write memlen.  */
@@ -2350,9 +2350,9 @@ cmd_record_save (char *args, int from_tt
               case record_end:
                 if (record_debug)
                   printf_filtered ("\
-  Writing record_end (1 + %d + %d bytes)\n", 
-				   sizeof (signal),
-				   sizeof (count));
+  Writing record_end (1 + %lu + %lu bytes)\n", 
+				   (unsigned long) sizeof (signal),
+				   (unsigned long) sizeof (count));
 		/* Write signal value.  */
 		signal = netorder32 (record_list->u.end.sigval);
 		bfdcore_write (obfd, osec, &signal,