From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite/sim: Remove redundant setting of timeout
Date: Tue, 04 Dec 2018 15:43:00 -0000 [thread overview]
Message-ID: <d726c7a6b7d096aa23857995eee3de03@polymtl.ca> (raw)
In-Reply-To: <20181204113345.717-1-andrew.burgess@embecosm.com>
On 2018-12-04 06:33, Andrew Burgess wrote:
> In the config/sim.exp file two functions are defined. Both of these
> functions define local timeout variables and then call gdb_expect,
> which (through a call to get_largest_timeout) will find the local
> definition of timeout.
>
> However, both of these functions set the local timeout to some
> arbitrary value and print a log message for this "new" timeout just
> before returning.
>
> As in both cases, the timeout is a local variable, this final setting
> of the timeout has no effect and can be removed.
Hi Andrew,
Can you verify whether the remaining "set timeout" in those functions
have any effect at all? As you said, they are just local variables, so
I don't expect them to influence the behavior of gdb_expect. Either we
need "global timeout", or we pass the timeout directly as an argument to
gdb_expect (the latter sounds better).
Simon
next prev parent reply other threads:[~2018-12-04 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 11:33 Andrew Burgess
2018-12-04 15:43 ` Simon Marchi [this message]
2018-12-04 15:54 ` Pedro Alves
2018-12-04 16:08 ` Simon Marchi
2018-12-04 16:11 ` Pedro Alves
2018-12-04 16:15 ` Simon Marchi
2018-12-04 16:33 ` Pedro Alves
2018-12-04 21:34 ` Andrew Burgess
2018-12-04 23:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d726c7a6b7d096aa23857995eee3de03@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox