From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH] gdb/testsuite/sim: Remove redundant setting of timeout
Date: Tue, 04 Dec 2018 11:33:00 -0000 [thread overview]
Message-ID: <20181204113345.717-1-andrew.burgess@embecosm.com> (raw)
In the config/sim.exp file two functions are defined. Both of these
functions define local timeout variables and then call gdb_expect,
which (through a call to get_largest_timeout) will find the local
definition of timeout.
However, both of these functions set the local timeout to some
arbitrary value and print a log message for this "new" timeout just
before returning.
As in both cases, the timeout is a local variable, this final setting
of the timeout has no effect and can be removed.
gdb/testsuite/ChangeLog:
* config/sim.exp (gdb_target_sim): Remove redundant adjustment of
local timeout variable before return.
(gdb_load): Likewise.
---
gdb/testsuite/ChangeLog | 6 ++++++
gdb/testsuite/config/sim.exp | 4 ----
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/config/sim.exp b/gdb/testsuite/config/sim.exp
index d9072febc6a..47146c6662e 100644
--- a/gdb/testsuite/config/sim.exp
+++ b/gdb/testsuite/config/sim.exp
@@ -37,8 +37,6 @@ proc gdb_target_sim { } {
return -1
}
}
- set timeout 10
- verbose "Timeout is now $timeout seconds" 2
return 0
}
@@ -67,8 +65,6 @@ proc gdb_load { arg } {
if $verbose>1 then {
send_user "Loaded $arg into $GDB\n"
}
- set timeout 30
- verbose "Timeout is now $timeout seconds" 2
return 0
}
-re "$gdb_prompt $" {
--
2.14.5
next reply other threads:[~2018-12-04 11:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 11:33 Andrew Burgess [this message]
2018-12-04 15:43 ` Simon Marchi
2018-12-04 15:54 ` Pedro Alves
2018-12-04 16:08 ` Simon Marchi
2018-12-04 16:11 ` Pedro Alves
2018-12-04 16:15 ` Simon Marchi
2018-12-04 16:33 ` Pedro Alves
2018-12-04 21:34 ` Andrew Burgess
2018-12-04 23:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204113345.717-1-andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox