From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite/sim: Remove redundant setting of timeout
Date: Tue, 04 Dec 2018 23:03:00 -0000 [thread overview]
Message-ID: <9e4227d4-235d-b22b-e08e-4a194d7ff590@redhat.com> (raw)
In-Reply-To: <20181204213420.GQ18841@embecosm.com>
On 12/04/2018 09:34 PM, Andrew Burgess wrote:
> Thanks both for the feedback.
>
> In the end I went for (a) - making timeout global, backing it up, etc
> just to print a log message seemed like overkill, especially when we
> adjust the timeout in lots of other places without any logging at all.
>
> With the logging gone, folding the timeout into the gdb_expect call
> seemed like an obvious cleanup.
>
> The new patch is below.
>
Fine with me.
> As having log messages about the timeout being adjusted could cause
> confusion I've removed all logging related to timeouts in this
> function, timeouts are adjusted thoughout the testsuite without any
Typo: "throughout"
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-12-04 23:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 11:33 Andrew Burgess
2018-12-04 15:43 ` Simon Marchi
2018-12-04 15:54 ` Pedro Alves
2018-12-04 16:08 ` Simon Marchi
2018-12-04 16:11 ` Pedro Alves
2018-12-04 16:15 ` Simon Marchi
2018-12-04 16:33 ` Pedro Alves
2018-12-04 21:34 ` Andrew Burgess
2018-12-04 23:03 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4227d4-235d-b22b-e08e-4a194d7ff590@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox