From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13699 invoked by alias); 4 Dec 2018 23:03:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13687 invoked by uid 89); 4 Dec 2018 23:03:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*r:2001 X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 23:03:26 +0000 Received: by mail-wr1-f68.google.com with SMTP id u3so17686529wrs.3 for ; Tue, 04 Dec 2018 15:03:26 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:75e6:857f:3506:a1f4? ([2001:8a0:f913:f700:75e6:857f:3506:a1f4]) by smtp.gmail.com with ESMTPSA id j76sm28370490wmf.26.2018.12.04.15.03.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 15:03:23 -0800 (PST) Subject: Re: [PATCH] gdb/testsuite/sim: Remove redundant setting of timeout To: Andrew Burgess References: <20181204113345.717-1-andrew.burgess@embecosm.com> <07a27e33-ca57-f4be-a055-8d4070b03554@redhat.com> <37e9f834bac94720a257148d45bd0325@polymtl.ca> <3c7ef445a7a59fa94f8eaee578d24177@polymtl.ca> <20181204213420.GQ18841@embecosm.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9e4227d4-235d-b22b-e08e-4a194d7ff590@redhat.com> Date: Tue, 04 Dec 2018 23:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181204213420.GQ18841@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-12/txt/msg00047.txt.bz2 On 12/04/2018 09:34 PM, Andrew Burgess wrote: > Thanks both for the feedback. > > In the end I went for (a) - making timeout global, backing it up, etc > just to print a log message seemed like overkill, especially when we > adjust the timeout in lots of other places without any logging at all. > > With the logging gone, folding the timeout into the gdb_expect call > seemed like an obvious cleanup. > > The new patch is below. > Fine with me. > As having log messages about the timeout being adjusted could cause > confusion I've removed all logging related to timeouts in this > function, timeouts are adjusted thoughout the testsuite without any Typo: "throughout" Thanks, Pedro Alves