From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23483 invoked by alias); 4 Dec 2018 15:43:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22444 invoked by uid 89); 4 Dec 2018 15:43:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:969 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 15:43:41 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wB4FhZ6q023802 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 4 Dec 2018 10:43:39 -0500 Received: by simark.ca (Postfix, from userid 112) id 15A1B1E74D; Tue, 4 Dec 2018 10:43:35 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id AC6831E475; Tue, 4 Dec 2018 10:43:34 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 04 Dec 2018 15:43:00 -0000 From: Simon Marchi To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite/sim: Remove redundant setting of timeout In-Reply-To: <20181204113345.717-1-andrew.burgess@embecosm.com> References: <20181204113345.717-1-andrew.burgess@embecosm.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00033.txt.bz2 On 2018-12-04 06:33, Andrew Burgess wrote: > In the config/sim.exp file two functions are defined. Both of these > functions define local timeout variables and then call gdb_expect, > which (through a call to get_largest_timeout) will find the local > definition of timeout. > > However, both of these functions set the local timeout to some > arbitrary value and print a log message for this "new" timeout just > before returning. > > As in both cases, the timeout is a local variable, this final setting > of the timeout has no effect and can be removed. Hi Andrew, Can you verify whether the remaining "set timeout" in those functions have any effect at all? As you said, they are just local variables, so I don't expect them to influence the behavior of gdb_expect. Either we need "global timeout", or we pass the timeout directly as an argument to gdb_expect (the latter sounds better). Simon