From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb/testsuite/lib/dwarf.exp: fix addr_size parameter comments
Date: Tue, 14 Jul 2020 23:18:59 -0400 [thread overview]
Message-ID: <d6af279e-5a19-9b08-bb8a-bcbae41c8e6e@simark.ca> (raw)
In-Reply-To: <a3cc2a69-5a35-ad29-1852-d5f2483be91b@simark.ca>
On 2020-07-13 5:33 p.m., Simon Marchi wrote:
> On 2020-07-13 3:37 p.m., Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Simon> - # addr_size n - the size of addresses, 32, 64, or default
>> Simon> + # addr_size n - the size of addresses, 4, 8, or default
>>
>> Maybe adding "in bytes" somewhere would be good.
>>
>> Tom
>>
>
> Sure, I can make them:
>
> # addr_size n - the size of addresses in bytes: 4, 8, or default
>
> Simon
>
I pushed it with this change.
Simno
prev parent reply other threads:[~2020-07-15 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 17:52 Simon Marchi
2020-07-13 19:37 ` Tom Tromey
2020-07-13 21:33 ` Simon Marchi
2020-07-15 3:18 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6af279e-5a19-9b08-bb8a-bcbae41c8e6e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox