From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4E4163861029 for ; Wed, 15 Jul 2020 03:19:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4E4163861029 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F0E431E111; Tue, 14 Jul 2020 23:19:00 -0400 (EDT) Subject: Re: [PATCH] gdb/testsuite/lib/dwarf.exp: fix addr_size parameter comments To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20200713175245.1650045-1-simon.marchi@efficios.com> <87h7ub6wam.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 14 Jul 2020 23:18:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 03:19:02 -0000 On 2020-07-13 5:33 p.m., Simon Marchi wrote: > On 2020-07-13 3:37 p.m., Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> >> Simon> - # addr_size n - the size of addresses, 32, 64, or default >> Simon> + # addr_size n - the size of addresses, 4, 8, or default >> >> Maybe adding "in bytes" somewhere would be good. >> >> Tom >> > > Sure, I can make them: > > # addr_size n - the size of addresses in bytes: 4, 8, or default > > Simon > I pushed it with this change. Simno