From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH] gdb/testsuite/lib/dwarf.exp: fix addr_size parameter comments
Date: Mon, 13 Jul 2020 13:52:45 -0400 [thread overview]
Message-ID: <20200713175245.1650045-1-simon.marchi@efficios.com> (raw)
The comments modified in this patch claim that the addr_size parameters
can take the value 32 or 64 (suggesting the value is in bits). In fact,
the expected value is in bytes, either 4 or 8.
The actual value in the DWARF info is in bytes. And we can see that the
default values used (if addr_size == "default") are:
if {$_cu_addr_size == "default"} {
if {[is_64_target]} {
set _cu_addr_size 8
} else {
set _cu_addr_size 4
}
}
gdb/testsuite/ChangeLog:
* lib/dwarf.exp (Dwarf::cu, Dwarf::tu, Dwarf::lines): Change valid
values in documentation for addr_size to 4 and 8.
Change-Id: I4a02dca2bb7992198864e545ef099f020f54ff2f
---
gdb/testsuite/lib/dwarf.exp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index a7dbe25fd458..5448f0ff5df6 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -1026,7 +1026,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
- # addr_size n - the size of addresses, 32, 64, or default
+ # addr_size n - the size of addresses, 4, 8, or default
# default = default
# fission 0|1 - boolean indicating if generating Fission debug info
# default = 0
@@ -1117,7 +1117,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
- # addr_size n - the size of addresses, 32, 64, or default
+ # addr_size n - the size of addresses, 4, 8, or default
# default = default
# fission 0|1 - boolean indicating if generating Fission debug info
# default = 0
@@ -1298,7 +1298,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
- # addr_size n - the size of addresses, 32, 64, or default
+ # addr_size n - the size of addresses, 4, 8, or default
# default = default
#
# LABEL is the label of the current unit (which is probably
--
2.26.2
next reply other threads:[~2020-07-13 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 17:52 Simon Marchi [this message]
2020-07-13 19:37 ` Tom Tromey
2020-07-13 21:33 ` Simon Marchi
2020-07-15 3:18 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713175245.1650045-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox