[PATCH] gdb/testsuite/lib/dwarf.exp: fix addr_size parameter comments

Simon Marchi
2020-07-13T17:52:55Z

The comments modified in this patch claim that the addr_size parameters
can take the value 32 or 64 (suggesting the value is in bits). In fact,
the expected value is in bytes, either 4 or 8.

The actual value in the DWARF info is in bytes. And we can see that the
default values used (if addr_size == "default") are:

if {$_cu_addr_size == "default"} {
if {[is_64_target]} {
set _cu_addr_size 8
} else {
set _cu_addr_size 4
}
}

gdb/testsuite/ChangeLog:

* lib/dwarf.exp (Dwarf::cu, Dwarf::tu, Dwarf::lines): Change valid
values in documentation for addr_size to 4 and 8.

Change-Id: I4a02dca2bb7992198864e545ef099f020f54ff2f
---
gdb/testsuite/lib/dwarf.exp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index a7dbe25fd458..5448f0ff5df6 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -1026,7 +1026,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
- # addr_size n - the size of addresses, 32, 64, or default
+ # addr_size n - the size of addresses, 4, 8, or default
# default = default
# fission 0|1 - boolean indicating if generating Fission debug info
# default = 0
@@ -1117,7 +1117,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
- # addr_size n - the size of addresses, 32, 64, or default
+ # addr_size n - the size of addresses, 4, 8, or default
# default = default
# fission 0|1 - boolean indicating if generating Fission debug info
# default = 0
@@ -1298,7 +1298,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
- # addr_size n - the size of addresses, 32, 64, or default
+ # addr_size n - the size of addresses, 4, 8, or default
# default = default
#
# LABEL is the label of the current unit (which is probably
--
2.26.2