[PATCH][gdb/testsuite] get_valueof: Don't output value in test name

[PATCH][gdb/testsuite] get_valueof: Don't output value in test name

[Tom de Vries]

Hi,

The get_valueof outputs the value it has read as part of the test name.  This
causes test names to vary from run to run, and adds some noise when diffing
test results.  e.g.:

-PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343920)
+PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343968)
-PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343920)
+PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343968)

This patch removes that, since it's probably not very useful.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] get_valueof: Don't output value in test name

2018-10-31  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (get_valueof): Don't output read value in test name.

---
 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index b4cf80e38a..5a5713b114 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5636,7 +5636,7 @@ proc get_valueof { fmt exp default {test ""} } {
     gdb_test_multiple "print${fmt} ${exp}" "$test" {
 	-re "\\$\[0-9\]* = (\[^\r\n\]*)\[\r\n\]*$gdb_prompt $" {
 	    set val $expect_out(1,string)
-	    pass "$test ($val)"
+	    pass "$test"
 	}
 	timeout {
 	    fail "$test (timeout)"

Re: [PATCH][gdb/testsuite] get_valueof: Don't output value in test name

[Simon Marchi]

On 2018-10-31 12:27, Tom de Vries wrote:
> Hi,
> 
> The get_valueof outputs the value it has read as part of the test name. 
>  This
> causes test names to vary from run to run, and adds some noise when 
> diffing
> test results.  e.g.:
> 
> -PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" 
> (140737488343920)
> +PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" 
> (140737488343968)
> -PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" 
> (140737488343920)
> +PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" 
> (140737488343968)
> 
> This patch removes that, since it's probably not very useful.
> 
> Tested on x86_64-linux.
> 
> OK for trunk?
> 
> Thanks,
> - Tom
> 
> [gdb/testsuite] get_valueof: Don't output value in test name
> 
> 2018-10-31  Tom de Vries  <tdevries@suse.de>
> 
> 	* lib/gdb.exp (get_valueof): Don't output read value in test name.
> 
> ---
>  gdb/testsuite/lib/gdb.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index b4cf80e38a..5a5713b114 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -5636,7 +5636,7 @@ proc get_valueof { fmt exp default {test ""} } {
>      gdb_test_multiple "print${fmt} ${exp}" "$test" {
>  	-re "\\$\[0-9\]* = (\[^\r\n\]*)\[\r\n\]*$gdb_prompt $" {
>  	    set val $expect_out(1,string)
> -	    pass "$test ($val)"
> +	    pass "$test"
>  	}
>  	timeout {
>  	    fail "$test (timeout)"

LGTM, thanks.

Simon