From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9191 invoked by alias); 31 Oct 2018 16:27:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9167 invoked by uid 89); 31 Oct 2018 16:27:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1388 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 16:27:31 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BA985AFFE; Wed, 31 Oct 2018 16:27:29 +0000 (UTC) Date: Wed, 31 Oct 2018 16:27:00 -0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Simon Marchi , Pedro Alves Subject: [PATCH][gdb/testsuite] get_valueof: Don't output value in test name Message-ID: <20181031162744.GA27881@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00754.txt.bz2 Hi, The get_valueof outputs the value it has read as part of the test name. This causes test names to vary from run to run, and adds some noise when diffing test results. e.g.: -PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343920) +PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" (140737488343968) -PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343920) +PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" (140737488343968) This patch removes that, since it's probably not very useful. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] get_valueof: Don't output value in test name 2018-10-31 Tom de Vries * lib/gdb.exp (get_valueof): Don't output read value in test name. --- gdb/testsuite/lib/gdb.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index b4cf80e38a..5a5713b114 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5636,7 +5636,7 @@ proc get_valueof { fmt exp default {test ""} } { gdb_test_multiple "print${fmt} ${exp}" "$test" { -re "\\$\[0-9\]* = (\[^\r\n\]*)\[\r\n\]*$gdb_prompt $" { set val $expect_out(1,string) - pass "$test ($val)" + pass "$test" } timeout { fail "$test (timeout)"