From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-152037-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 108028 invoked by alias); 31 Oct 2018 16:43:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 108016 invoked by uid 89); 31 Oct 2018 16:43:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 16:43:50 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9VGhhVd021868	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Wed, 31 Oct 2018 12:43:48 -0400
Received: by simark.ca (Postfix, from userid 112)	id 92BB71EAB6; Wed, 31 Oct 2018 12:43:43 -0400 (EDT)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id C3D181E514;	Wed, 31 Oct 2018 12:43:41 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 31 Oct 2018 16:43:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@ericsson.com>,        Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH][gdb/testsuite] get_valueof: Don't output value in test name
In-Reply-To: <20181031162744.GA27881@delia>
References: <20181031162744.GA27881@delia>
Message-ID: <d5a6c864cbc3ce5380c29ddd2df5f442@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.6
X-IsSubscribed: yes
X-SW-Source: 2018-10/txt/msg00755.txt.bz2

On 2018-10-31 12:27, Tom de Vries wrote:
> Hi,
> 
> The get_valueof outputs the value it has read as part of the test name. 
>  This
> causes test names to vary from run to run, and adds some noise when 
> diffing
> test results.  e.g.:
> 
> -PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" 
> (140737488343920)
> +PASS: gdb.guile/scm-ports.exp: buffered: get valueof "$sp" 
> (140737488343968)
> -PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" 
> (140737488343920)
> +PASS: gdb.guile/scm-ports.exp: unbuffered: get valueof "$sp" 
> (140737488343968)
> 
> This patch removes that, since it's probably not very useful.
> 
> Tested on x86_64-linux.
> 
> OK for trunk?
> 
> Thanks,
> - Tom
> 
> [gdb/testsuite] get_valueof: Don't output value in test name
> 
> 2018-10-31  Tom de Vries  <tdevries@suse.de>
> 
> 	* lib/gdb.exp (get_valueof): Don't output read value in test name.
> 
> ---
>  gdb/testsuite/lib/gdb.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index b4cf80e38a..5a5713b114 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -5636,7 +5636,7 @@ proc get_valueof { fmt exp default {test ""} } {
>      gdb_test_multiple "print${fmt} ${exp}" "$test" {
>  	-re "\\$\[0-9\]* = (\[^\r\n\]*)\[\r\n\]*$gdb_prompt $" {
>  	    set val $expect_out(1,string)
> -	    pass "$test ($val)"
> +	    pass "$test"
>  	}
>  	timeout {
>  	    fail "$test (timeout)"

LGTM, thanks.

Simon