From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build on macOS
Date: Wed, 11 Dec 2019 14:07:00 -0000 [thread overview]
Message-ID: <d0ed35c0-8171-2c4b-7d0a-4e1fbf01e573@simark.ca> (raw)
In-Reply-To: <87sglrdl58.fsf@tromey.com>
On 2019-12-11 8:52 a.m., Tom Tromey wrote:
> @@ -36,8 +37,31 @@
> #endif
>
> #ifdef USE_PTHREAD_SETNAME_NP
> +
> #include <pthread.h>
> -#endif
> +
> +DIAGNOSTIC_PUSH
> +DIAGNOSTIC_IGNORE_UNUSED_FUNCTION
> +
> +/* Handle platform discrepancies in pthread_setname_np: macOS uses a
> + single-argument form, while Linux uses a two-argument form. This
> + wrapper template handles the difference. */
This comment still mentions "template", you might want to change it?
Otherwise, that LGTM.
Simon
next prev parent reply other threads:[~2019-12-11 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 21:47 Tom Tromey
2019-12-11 1:37 ` Simon Marchi
2019-12-11 13:52 ` Tom Tromey
2019-12-11 14:07 ` Simon Marchi [this message]
2020-01-31 14:43 ` Kevin Buettner
2020-01-31 16:52 ` Tom Tromey
2020-01-31 21:40 ` Kevin Buettner
2020-02-05 18:37 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ed35c0-8171-2c4b-7d0a-4e1fbf01e573@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox