Re: [PATCH] Fix build on macOS

[Kevin Buettner <kevinb@redhat.com>]

On Tue, 10 Dec 2019 14:47:17 -0700
Tom Tromey <tromey@adacore.com> wrote:

> PR build/25268 points out that the build fails on macOS, because on
> macOS the "pthread_setname_np" function takes a single argument.
> 
> This patch fixes the problem, by introducing a new template adapter
> function that handles both styles of pthread_setname_np.  This is a
> technique I learned from Alexandre Oliva, and avoids the need for a
> complicated autoconf check.
> 
> This change also meant moving the pthread_setname_np call to the
> thread function, because macOS only permits setting the name of the
> current thread.  This means that there can be a brief window when gdb
> will see the wrong name; but I think this is a minor concern.
> 
> Tested by rebuilding on x86-64 Fedora 30, and on macOS High Sierra.
> On Linux I also debugged gdb to ensure that the thread names are still
> set correctly.
> 
> gdb/ChangeLog
> 2019-12-10  Tom Tromey  <tromey@adacore.com>
> 
> 	PR build/25268:
> 	* gdbsupport/thread-pool.c (set_thread_name): New template
> 	function.
> 	(thread_pool::set_thread_count): Don't call pthread_setname_np.
> 	(thread_pool::thread_function): Call set_thread_name.

Did this ever go in?

If not, I think it looks reasonable.

Kevin