From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix build on macOS
Date: Wed, 05 Feb 2020 18:37:00 -0000 [thread overview]
Message-ID: <CAPTJ0XGp5-o9Xh=Tk83btTai+NAFdzE_xRhDMB0CT_h7NeeoHA@mail.gmail.com> (raw)
In-Reply-To: <20200131140242.14fd9776@f31-4.lan>
On Fri, Jan 31, 2020 at 4:02 PM Kevin Buettner <kevinb@redhat.com> wrote:
>
> On Fri, 31 Jan 2020 15:43:29 +0100
> Tom Tromey <tromey@adacore.com> wrote:
>
> > >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
> >
> > >> gdb/ChangeLog
> > >> 2019-12-10 Tom Tromey <tromey@adacore.com>
> > >>
> > >> PR build/25268:
> > >> * gdbsupport/thread-pool.c (set_thread_name): New template
> > >> function.
> > >> (thread_pool::set_thread_count): Don't call pthread_setname_np.
> > >> (thread_pool::thread_function): Call set_thread_name.
> >
> > Kevin> Did this ever go in?
> >
> > Kevin> If not, I think it looks reasonable.
> >
> > Something like it did, and then there was another fix after that.
>
> Yeah, I saw that there was a second fix, but I didn't see the template
> stuff, which I thought was pretty cool.
The ultimate solution used function overloads instead of templates,
which seems simpler.
Christian
prev parent reply other threads:[~2020-02-05 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 21:47 Tom Tromey
2019-12-11 1:37 ` Simon Marchi
2019-12-11 13:52 ` Tom Tromey
2019-12-11 14:07 ` Simon Marchi
2020-01-31 14:43 ` Kevin Buettner
2020-01-31 16:52 ` Tom Tromey
2020-01-31 21:40 ` Kevin Buettner
2020-02-05 18:37 ` Christian Biesinger via gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XGp5-o9Xh=Tk83btTai+NAFdzE_xRhDMB0CT_h7NeeoHA@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=kevinb@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox