From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39862 invoked by alias); 5 Feb 2020 18:37:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39854 invoked by uid 89); 5 Feb 2020 18:37:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.210.68, H*RU:209.85.210.68, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Feb 2020 18:37:09 +0000 Received: by mail-ot1-f68.google.com with SMTP id i6so2891294otr.7 for ; Wed, 05 Feb 2020 10:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2IwGKzahpAONb+3TtXQMVM8NVBoGPl0NvcRo0SGwdGE=; b=KQDzJJeIRw6lrG2Cdko8li6gMAcwrE/N6qCpjQXJ4CEpDNL+uWyWWIdAOWMtKV+2Qw hWu3R3z2SRlnHSW38fG0VdyKzGmNqIP55tsUGSvboSzRa/yy0xCeod/vHGxohzAUG+Kd VhvjDWxg62Na97kJP1vHge9TwG1SIwNvglu4M6qx2LnzWJcJomPJUs2qNRd41Y7lrYGj JXrcm+k23gMjEhQq7wJDIHE0FARkXgIE339Nbl/0DHRTHNaJfe2PT2+NNvV0uuwmjlOr kPwnOhgdkkhh55Oo+djPCRRsWGAsLbulPVxqwYWd/jDRM0aiAIJMLiDkUeL0ictQ5XON zmRw== MIME-Version: 1.0 References: <20191210214717.25680-1-tromey@adacore.com> <20200131072300.5062774a@f31-4.lan> <87ftfvwusu.fsf@tromey.com> <20200131140242.14fd9776@f31-4.lan> In-Reply-To: <20200131140242.14fd9776@f31-4.lan> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 05 Feb 2020 18:37:00 -0000 Message-ID: Subject: Re: [PATCH] Fix build on macOS To: Kevin Buettner Cc: Tom Tromey , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00111.txt.bz2 On Fri, Jan 31, 2020 at 4:02 PM Kevin Buettner wrote: > > On Fri, 31 Jan 2020 15:43:29 +0100 > Tom Tromey wrote: > > > >>>>> "Kevin" == Kevin Buettner writes: > > > > >> gdb/ChangeLog > > >> 2019-12-10 Tom Tromey > > >> > > >> PR build/25268: > > >> * gdbsupport/thread-pool.c (set_thread_name): New template > > >> function. > > >> (thread_pool::set_thread_count): Don't call pthread_setname_np. > > >> (thread_pool::thread_function): Call set_thread_name. > > > > Kevin> Did this ever go in? > > > > Kevin> If not, I think it looks reasonable. > > > > Something like it did, and then there was another fix after that. > > Yeah, I saw that there was a second fix, but I didn't see the template > stuff, which I thought was pretty cool. The ultimate solution used function overloads instead of templates, which seems simpler. Christian