From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162001-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25692 invoked by alias); 11 Dec 2019 14:07:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25199 invoked by uid 89); 11 Dec 2019 14:07:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 14:07:20 +0000
Received: from [10.0.0.11] (unknown [192.222.164.54])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 31F7E1E5F9;	Wed, 11 Dec 2019 09:07:18 -0500 (EST)
Subject: Re: [PATCH] Fix build on macOS
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
References: <20191210214717.25680-1-tromey@adacore.com> <0aa60cb1-2138-6568-f99a-a9f54fa39f45@simark.ca> <87sglrdl58.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <d0ed35c0-8171-2c4b-7d0a-4e1fbf01e573@simark.ca>
Date: Wed, 11 Dec 2019 14:07:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <87sglrdl58.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-12/txt/msg00409.txt.bz2

On 2019-12-11 8:52 a.m., Tom Tromey wrote:
> @@ -36,8 +37,31 @@
>  #endif
>  
>  #ifdef USE_PTHREAD_SETNAME_NP
> +
>  #include <pthread.h>
> -#endif
> +
> +DIAGNOSTIC_PUSH
> +DIAGNOSTIC_IGNORE_UNUSED_FUNCTION
> +
> +/* Handle platform discrepancies in pthread_setname_np: macOS uses a
> +   single-argument form, while Linux uses a two-argument form.  This
> +   wrapper template handles the difference.  */

This comment still mentions "template", you might want to change it?

Otherwise, that LGTM.

Simon