[PATCH 0/6] Fix aggregate types, synthetic pointers, and computed locations bug

[Andrew Burgess <aburgess@redhat.com>]

A recent Fedora GDB bug got me looking at an issue relating to
synthetic pointers in aggregate types with computed locations.  Turns
out there was already an upstream bug for this issue (PR gdb/30693).

Patches #1 and #2 are some general cleanup in areas that I will then
touch in later patches.

Patch #3 is the actual fix for the original bug.  But while writing
this I spotted another issue.

Patches #4 and #5 are some clean up, argument renaming, and argument
removal, that I think contributed to the confusion that caused the
next bug.

Patch #6 fixes another bug related to the embedded offset not always
being taken into account when handling computed locations of synthetic
pointers.

Thanks,
Andrew

---

Andrew Burgess (6):
  gdb: int to bool conversion in valprint.{c,h}
  gdb: use TARGET_CHAR_BIT more in dwarf2/expr.c
  gdb: fix coerce_pieced_ref for multi-piece values
  gdb: rename argument in valprint_check_validity
  gdb: remove embedded_offset argument that is always 0
  gdb: use value::embedded_offset in check_pieced_synthetic_pointer

 gdb/dwarf2/expr.c                             | 142 ++++++++-----
 .../multi-piece-inherited-bitfield.c          |  25 +++
 .../multi-piece-inherited-bitfield.exp        | 151 ++++++++++++++
 .../gdb.dwarf2/multi-piece-primitive-field.c  |  25 +++
 .../multi-piece-primitive-field.exp           | 190 ++++++++++++++++++
 gdb/valops.c                                  |   3 +-
 gdb/valprint.c                                | 114 +++++------
 gdb/valprint.h                                |  22 +-
 8 files changed, 550 insertions(+), 122 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-inherited-bitfield.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-inherited-bitfield.exp
 create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-primitive-field.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-primitive-field.exp


base-commit: 2d7f2dbbd4adadf7c388fa0d8b9ce95d9dfde641
-- 
2.25.4