Re: [PATCH 5/6] gdb: remove embedded_offset argument that is always 0

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> But it turns out that the only value that is ever passed to this
Andrew> function is zero.

Andrew> I believe that, like the last commit, the embedded_offset is actually
Andrew> representing the offset of a field within a value.  However, in all of
Andrew> the use cases, the "field" being accessed is the entire value, hence
Andrew> why we always pass 0, we are asking about the whole value starting
Andrew> from the very beginning.

Andrew> Given this, I couldn't bring myself to rename the argument.  Let's just
Andrew> remove it.  It turns out that there's a bunch of functions in
Andrew> valprint.c that take an argument called embedded_offset, which are
Andrew> always zero.

Andrew> This commit removes the argument, and updates the code to assume zero.

Looks good, thanks.

I've often wondered if the "embedded offset" stuff could be removed from
value.

Anyway
Approved-By: Tom Tromey <tom@tromey.com>

Tom