Re: [PATCH 3/6] gdb: fix coerce_pieced_ref for multi-piece values

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> In addition, there is an error for the case where multiple pieces are
Andrew> used to describe the location of a synthetic pointer.  This case is
Andrew> technically allowed by check_pieced_synthetic_pointer, but supporting
Andrew> this would require changes to indirect_synthetic_pointer, so I propose
Andrew> leaving that until we see such a case in the wild.

I think that's totally fine.  It's probably just an accident of the
implementation that this is even allowed.  Like, I don't think that
makes any sense in DWARF, and the synthetic pointer code is actually
DWARF-specific.

Andrew> For now I'm leaving things as they are.  My assumption is that the
Andrew> number of pieces used to represent a value is pretty low, so the
Andrew> search is actually pretty cheap.

Andrew> There's a new test that uses the DWARF assembler to create a
Andrew> representative example of a multi-piece aggregate that contains a
Andrew> synthetic pointer member variable.  This test triggers the assertion
Andrew> before this commit.

I think this looks good.

Approved-By: Tom Tromey <tom@tromey.com>

Tom