From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ASWXJlYaBmo9kDoAWB0awg (envelope-from ) for ; Thu, 14 May 2026 14:54:14 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E6mO9wS8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8B9E61E067; Thu, 14 May 2026 14:54:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03D1A1E067 for ; Thu, 14 May 2026 14:54:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41BAC4C91745 for ; Thu, 14 May 2026 18:54:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41BAC4C91745 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E6mO9wS8 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id DB2EA4C900EE for ; Thu, 14 May 2026 18:53:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB2EA4C900EE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB2EA4C900EE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778784825; cv=none; b=kwPTT502UZrOmbBkXEmWo3H5SLw/vsoZMa0G2LBFVcjXPxXDF2cXZm4H9M9c2JDJfMJpF35Val8Q2gCzKUckpc6Qehiu2/30FxcI5zfrk+yGAaFBkkPspBiyOdITnNNzxVquA2awqVr9pmZ0X6zyJQxXPd+np1DzhnK8uZNkPHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778784825; c=relaxed/simple; bh=vwkLV0UuNFxFcp26uXV5V9ZP54ES1qkrAyqLTib6TUc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oRU/y+hm3Fu8h3IMyZcj5NA8Sw2gIPtmEA8i5gTU3xSFXrnzdSOUw3Bovdv+9+fASrBqVNlJHdpnTWfm+iO1GL/nQc5YM7RIXeH0W3H1gSPzH+7trVB/AGk5482Fp84AMPHlTY6Ec6ooG181fW4FwwoOvZ/cSp1McJuh5Hz1284= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E6mO9wS8 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB2EA4C900EE Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id NZuOw4Ex2nwj2NbBnwjbPM; Thu, 14 May 2026 18:53:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NbBmwobPdyM4lNbBmwG8hA; Thu, 14 May 2026 18:53:43 +0000 X-Authority-Analysis: v=2.4 cv=CJwqXQrD c=1 sm=1 tr=0 ts=6a061a37 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=TEuS2q_UA4OQeGM0EqQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q16D/ya16AVFAZ9HJnc7uTlW6j8TSKdLW1MKTQZr0iw=; b=E6mO9wS8xwVxdeQKk/9YjMuLfz cNulVnD/A++ZTsUK1fbf5Pt86En38BuFL4WEIKPHY++gMXZPOcW5t7r2/LwDlL9cfe2yKPHMjNVXE PIxsg4fQOijBf0hrZh5pLhN9i; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:51272 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wNbBm-00000001bm6-1M6a; Thu, 14 May 2026 12:53:42 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] gdb: fix coerce_pieced_ref for multi-piece values In-Reply-To: <9d1e7f6587074e0b6effbda010cb643d897bb13b.1778579473.git.aburgess@redhat.com> (Andrew Burgess's message of "Tue, 12 May 2026 11:07:24 +0100") References: <9d1e7f6587074e0b6effbda010cb643d897bb13b.1778579473.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 14 May 2026 12:53:41 -0600 Message-ID: <87ecjdkekq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wNbBm-00000001bm6-1M6a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:51272 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOg+JGx5f5GZrkPFCAoknmapS0ZWSWGxTkc6V6Eq2lJXvQMCNFFnqKg8VvJCUIod4Pv00uKpJ9Te6ubMkWYXnr4HeV3zHNKVAhBrssspnYZbaAF1z9eu B/ZsU20eBlpqiVvcmJ/JHErUd09UtFQWkn5WjzWWpjyo4JvrVkRKplh86Dz/ILkY8cKXerjgfg7ZYlqw2efx/Nhet/NYDfAz88M= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> In addition, there is an error for the case where multiple pieces are Andrew> used to describe the location of a synthetic pointer. This case is Andrew> technically allowed by check_pieced_synthetic_pointer, but supporting Andrew> this would require changes to indirect_synthetic_pointer, so I propose Andrew> leaving that until we see such a case in the wild. I think that's totally fine. It's probably just an accident of the implementation that this is even allowed. Like, I don't think that makes any sense in DWARF, and the synthetic pointer code is actually DWARF-specific. Andrew> For now I'm leaving things as they are. My assumption is that the Andrew> number of pieces used to represent a value is pretty low, so the Andrew> search is actually pretty cheap. Andrew> There's a new test that uses the DWARF assembler to create a Andrew> representative example of a multi-piece aggregate that contains a Andrew> synthetic pointer member variable. This test triggers the assertion Andrew> before this commit. I think this looks good. Approved-By: Tom Tromey Tom