From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CCYhCZqYBGq9gDYAWB0awg (envelope-from ) for ; Wed, 13 May 2026 11:28:26 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FRg21pf9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 10A821E067; Wed, 13 May 2026 11:28:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 74F261E067 for ; Wed, 13 May 2026 11:28:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74C834BB5880 for ; Wed, 13 May 2026 15:28:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 74C834BB5880 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FRg21pf9 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D7A6D4BB1C3E for ; Wed, 13 May 2026 15:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7A6D4BB1C3E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D7A6D4BB1C3E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778686068; cv=none; b=VEZ6wRZLDtJPpqI42n/K61e9IiuVQtNHCrnOvMzXWby2kRX0ziCc+g7k9pA+K4swQ2abdYZDp/sWNyO8i24ttogmtu69bVFDKamK0VvgRWpoNVsJ7R9BPLjpFScdKTvt3gQSTNOlJxaskH6sx/mFb4n2PCafdyFI9PM0+HmDEXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778686068; c=relaxed/simple; bh=C78E4SP2Hz8A0kutYGmfndJSRhoyfLjmreP2FUPtMqc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Y+XhPtjyKHoYzdPHAx33esaqdhBboFlKVrMVNX1A95oiNT6Gny2ez1TNUQqSkeWWs5lnJx5hLZnRp4ngXyn9OIn7oyQk5BOLcbj0G8vtRmkQOBTYAb7iz/NitjbTrHX4vp+SqtauNZy88aWU/eIRRZDrIl/N5LXwt+AbFNNMI14= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FRg21pf9 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7A6D4BB1C3E Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id N8mSwzOxPjw8YNBUwwDQJO; Wed, 13 May 2026 15:27:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NBUvwCWEXpzaiNBUvwVlbv; Wed, 13 May 2026 15:27:45 +0000 X-Authority-Analysis: v=2.4 cv=MLJgmNZl c=1 sm=1 tr=0 ts=6a049872 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=X_VZfFH7ksS91Iz6aykA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eVbTh1Cu5ADZ6sfc5VOVC6k1cSNIRSE8bJsHM8Ix9fg=; b=FRg21pf9jN4Atf7fT0j0yyuX6H nz8ZCVsIvmX3aZ9C8xoNjj7UNYhU+VlaGchBQggQx2P7uANLmS0EqI2WDYJSTfhPzX6kpcXe252Yq vjy8bgtVL4UhgldyLMrHYJBGc; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:54834 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wNBUu-00000001Hmz-45Au; Wed, 13 May 2026 09:27:45 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] gdb: remove embedded_offset argument that is always 0 In-Reply-To: <1281d9563073d028c50690fa26bbe165b9c7beff.1778579473.git.aburgess@redhat.com> (Andrew Burgess's message of "Tue, 12 May 2026 11:07:26 +0100") References: <1281d9563073d028c50690fa26bbe165b9c7beff.1778579473.git.aburgess@redhat.com> X-Attribution: Tom Date: Wed, 13 May 2026 09:27:43 -0600 Message-ID: <87lddnl47k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wNBUu-00000001Hmz-45Au X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:54834 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfG2gB9IBByjmhvkDvrqhJFv0heiulwHVHJKvs2KND2m2PsX70lq+jObFXrEnv3BfN8CDRngIshGoV9zBbtXqI1S/97eYIWfIChdccxxcvg+9lQoorQ4l e+rvTmfOyb1rtiu5bUNwV/oOam8Hs5+cAJ4YJjhA4I7lQrhYI5G1LNMZJyUR2Gtc1ugdhiwAGs9pAGYuerQnyo8KTUZCwqsD2gc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> But it turns out that the only value that is ever passed to this Andrew> function is zero. Andrew> I believe that, like the last commit, the embedded_offset is actually Andrew> representing the offset of a field within a value. However, in all of Andrew> the use cases, the "field" being accessed is the entire value, hence Andrew> why we always pass 0, we are asking about the whole value starting Andrew> from the very beginning. Andrew> Given this, I couldn't bring myself to rename the argument. Let's just Andrew> remove it. It turns out that there's a bunch of functions in Andrew> valprint.c that take an argument called embedded_offset, which are Andrew> always zero. Andrew> This commit removes the argument, and updates the code to assume zero. Looks good, thanks. I've often wondered if the "embedded offset" stuff could be removed from value. Anyway Approved-By: Tom Tromey Tom