From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MQVkMhf8Amr1WjMAWB0awg (envelope-from ) for ; Tue, 12 May 2026 06:08:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZBgWvi+W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A22CF1E093; Tue, 12 May 2026 06:08:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 157761E093 for ; Tue, 12 May 2026 06:08:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 539EC4BB1C34 for ; Tue, 12 May 2026 10:08:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 539EC4BB1C34 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZBgWvi+W Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 393F84BA2E32 for ; Tue, 12 May 2026 10:07:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 393F84BA2E32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 393F84BA2E32 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778580454; cv=none; b=f2UrQ+hDB1SvFlhen92mmvz5pZYL547tFTAowHlxXXyKsa4orQXw/ORLII+kSfc9X3RitiAfTMMe/6rCLKfUKHaQ3f0rItgecLO2ueC2TsITY+wDS0LoxUapgdN6JqaFegSevrU5m2Fy/E1ymhBUW3WOJ4wUi17LQ7mTwDbyrXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778580454; c=relaxed/simple; bh=C6xepGpcX9ApC5xSQp7TXwXd85XZsHe2aDDWyPpasjY=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=buL3v493BbqYIiulSyzAZSPrWyiCj9ayTajg0J8tAWge4GlJArKjPwfoqjJ3Ha4jY60D+gHAIgcqfy4pMP/juFUP1skfSkvYtEKgt2oeBY8fm9g/CJZ71ecLkH1v+h83XWaDqstzemqLrrP2wsaMjV9/rfUqtaVHf36QX/bA0yk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZBgWvi+W DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 393F84BA2E32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778580453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nn0F2i7eFC1VqVvJHldllXtcbCYJrALz3LZUZXOo0gE=; b=ZBgWvi+WwgbAhxVE1NdZgu3hMsTFASCsdNunGcTTbALKSJmSWF4o/+CVfQSchQl0rj+vvl At//RmCmfJAmAM9OFRWLTQI8GrZDdTr1UQ1QeJ5PLAltIlZnhqIVw4fvtWUQRQJwDBZ32f Y/eIgXxV6G3MfRijsDRGrQQQqptiIY8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-z2vAzMwMM625Olz3uxV2Ug-1; Tue, 12 May 2026 06:07:32 -0400 X-MC-Unique: z2vAzMwMM625Olz3uxV2Ug-1 X-Mimecast-MFC-AGG-ID: z2vAzMwMM625Olz3uxV2Ug_1778580451 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-45b7ff2140eso272434f8f.3 for ; Tue, 12 May 2026 03:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778580450; x=1779185250; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nn0F2i7eFC1VqVvJHldllXtcbCYJrALz3LZUZXOo0gE=; b=j6NEvX1de7UwbQlH0heodoLMUtexhq42GHj5N4jQ4+rX/iTZE9KkgPhTt4EnWXzQQY Wyaezt2TVc6kESjoplo+P2rsGewuglyKluvtOjwcl6eVT4YRv5cRzG5WbmP2KtkITekQ EubAra4AnI24pQKCAY3vhofMRNbSFppeLYY6MFdQQgPDDSMfqBI0FpP/qPHmP9udgLM9 x0J4KO/17jgr0PaEgV2Rn8wpSvS9LVYi4zikk4+jyjj1guDZzIguhRT5HdN9XeHsFAGM zkZ/SqhNdyxJgty616uvY3QecbSb3YP/oxBZQFzIHgoTo0X3UbCzVwo5v+KqWI0xBey9 nGjQ== X-Gm-Message-State: AOJu0Yy556iJM8t+gcQXXSG8jDKRpy1s7FIJLgk+650V+UCKGr3p8dj4 CkUVQZiwSomFoFcggx51VTRIqfCVdGs2X4f65NWCO1e6BOKgKcu+gmIr2B9GI61eR9EY7oo6Epx zv9YCXXm0ChWx8v6JEBhcfDtNd9gl7xqqnAwqbWnrK0rf1gYt6hDHFy/hV2EnnG9XJv6nAi0eKS H4ki0fKUsmdmqH3fkYf2HBJvtBIOHqapi3ra4C9XbUp3viN/0= X-Gm-Gg: Acq92OHoiVvCT4KO47hPkHQ3fZG3H1KWdDIm51Ce7f8GPC94K4Q5aUaYgAR7k96PAus sRmb2+X0RQnAHICy3enS5Csqrtsatb4Y7yFg1ulexEzI0Yun+nSiuuvKpND6AHQSJnJy9xcsLxg JCmI1dLDMVnBBltFeNKy+nKB/gqg7XHL9rKBbbUW4AQncI0i7J0A4gQxHgkF+PEb3foQJDVwuQ0 Bpmv+8Gy3bmOPA1onyta31l5aG9eDq/hU4j8xiCL4S1FqP1gZb2yauph9CAeJvYJ8XyO9tPp8Y5 JPN65v8bsxF40Y6ROzb0KE68AuFCw4018nMBTdY8qQNx+EnMeeUFOR+8+Po9yXpKBTofAE78Zya sHIs++UdwcH/GlWLH X-Received: by 2002:a05:600c:350a:b0:48a:5565:ec3d with SMTP id 5b1f17b1804b1-48e676ac38fmr281616945e9.22.1778580450626; Tue, 12 May 2026 03:07:30 -0700 (PDT) X-Received: by 2002:a05:600c:350a:b0:48a:5565:ec3d with SMTP id 5b1f17b1804b1-48e676ac38fmr281616355e9.22.1778580450094; Tue, 12 May 2026 03:07:30 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f42a4c5sm14439015e9.19.2026.05.12.03.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 03:07:29 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/6] Fix aggregate types, synthetic pointers, and computed locations bug Date: Tue, 12 May 2026 11:07:21 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: k7-NZatH9SOfHfdjSRJnT1QftCpM2cQu_AH-aZ4c4z4_1778580451 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org A recent Fedora GDB bug got me looking at an issue relating to synthetic pointers in aggregate types with computed locations. Turns out there was already an upstream bug for this issue (PR gdb/30693). Patches #1 and #2 are some general cleanup in areas that I will then touch in later patches. Patch #3 is the actual fix for the original bug. But while writing this I spotted another issue. Patches #4 and #5 are some clean up, argument renaming, and argument removal, that I think contributed to the confusion that caused the next bug. Patch #6 fixes another bug related to the embedded offset not always being taken into account when handling computed locations of synthetic pointers. Thanks, Andrew --- Andrew Burgess (6): gdb: int to bool conversion in valprint.{c,h} gdb: use TARGET_CHAR_BIT more in dwarf2/expr.c gdb: fix coerce_pieced_ref for multi-piece values gdb: rename argument in valprint_check_validity gdb: remove embedded_offset argument that is always 0 gdb: use value::embedded_offset in check_pieced_synthetic_pointer gdb/dwarf2/expr.c | 142 ++++++++----- .../multi-piece-inherited-bitfield.c | 25 +++ .../multi-piece-inherited-bitfield.exp | 151 ++++++++++++++ .../gdb.dwarf2/multi-piece-primitive-field.c | 25 +++ .../multi-piece-primitive-field.exp | 190 ++++++++++++++++++ gdb/valops.c | 3 +- gdb/valprint.c | 114 +++++------ gdb/valprint.h | 22 +- 8 files changed, 550 insertions(+), 122 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-inherited-bitfield.c create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-inherited-bitfield.exp create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-primitive-field.c create mode 100644 gdb/testsuite/gdb.dwarf2/multi-piece-primitive-field.exp base-commit: 2d7f2dbbd4adadf7c388fa0d8b9ce95d9dfde641 -- 2.25.4