Re: [PATCH v2 3/4] gdb, gdbserver, gdbsupport: include early header files with `-include`

[Simon Marchi <simark@simark.ca>]

On 3/26/24 11:31 AM, Pedro Alves wrote:
> You said a lot of different things, so I'm not sure which part I'd be agreeing with.  :-)

Sorry about that.

> gdbreplay is a separate program that happens share a few bits of code with gdbserver, but
> not that much.  It currently includes common-defs.h at the top of its source file.
> So I think the really simplest is to make the rule for gdbreplay.o you were
> adding use "-include common-defs.h".  Or add a new gdbreplay.h header that includes
> common-defs.h and -include that one.
> 
> Anything else than that seems like a distraction at this point, and I wouldn't call those
> other options simpler.  The look certainly more debatable to me.

Ok, I'll keep the special rule for gdbreplay.o and make it -include
common-defs.h.

It's a bit weird because gdbreplay is made of gdbreplay.o, utils.o and
version.o.  The former includes common-defs.h, while the last two
include server.h.  But it works like that today, and I don't need to
change it.

Simon